Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 13, 2022

Fixes #16528

Depends on: #16510

Description

This PR adds a new property recommended to enhanced_site_creation_site_design_selected. the property is set to true if the design chosen is from the recommended category, otherwise false

To test:

To fully test this PR the group field (ref D80005) and recommended designs (ref D80579) should be available on the backend or sandbox.

Recommended design

  1. Start the site creation flow
  2. Proceed to the design selection
  3. Tap on a design on the recommended section
  4. Press Choose
  5. Verify that an event is emitted with the recommended property set to true
    e.g. 🔵 Tracked: enhanced_site_creation_site_design_selected, Properties: {"template":"blog-new","default_tab_experiment":"dashboard","recommended":true}

Non-recommended design

  1. Start the site creation flow
  2. Proceed to the design selection
  3. Tap on a design that is not recommended
  4. Press Choose
  5. Verify that an event is emitted with the recommended property set to false
    e.g. 🔵 Tracked: enhanced_site_creation_site_design_selected, Properties: {"template":"about","default_tab_experiment":"dashboard","recommended":false}

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    Extended tests in HomePagePickerViewModelTest

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis added [Type] Task Site Creation Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels May 13, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 13, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis changed the base branch from trunk to task/16503-recommend-vertical-designs May 13, 2022 04:32
@antonis antonis marked this pull request as ready for review May 13, 2022 04:43
@antonis antonis requested a review from a team May 13, 2022 04:43
@antonis antonis force-pushed the task/16528-track-recommended-property branch from 8aa7c8e to 3ddba5e Compare May 13, 2022 04:47
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you for implementing this @antonis 🙇

@ovitrif ovitrif merged commit 8a16b16 into task/16503-recommend-vertical-designs May 13, 2022
@ovitrif ovitrif deleted the task/16528-track-recommended-property branch May 13, 2022 10:25
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Site Creation [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Site Design Revamp] Preview View - On design selection send recommended property with Tracks event

3 participants