-
Notifications
You must be signed in to change notification settings - Fork 846
Use blog token to request the jetpack.updateBlog XMLRPC endpoint #16698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Stats
- Visit home page, make sure that page view is recorded in stats
- Visit home page in AMP view
- Visit post page in non-AMP and AMP view
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
56c669e to
8afe88b
Compare
9ab6cb5 to
1ef9f66
Compare
1ef9f66 to
f4b64de
Compare
This is an automated check which relies on E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16698 |
fgiannar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* master: (23 commits) Premium Blocks: set blocks availability (#16898) Compat Package: Fix method declaration compatibility (#16900) Jetpack Dashboard: More meaningful error notices. (#16883) Connection REST API: Unit test for the `remote_authorize` request. (#16879) use blog token to request jetpack.updateBlog (#16698) Improve Story block media loading (#16663) Simplify error notices for broken connections (#16655) Use new heartbeat package (#16285) wrap-paid-block: remove component. deprecated. (#16895) Social Previews: improve preview description handling (#16889) Stats module use blog token (#16727) Form Block: add a new Consent Field, a new Newsletter setting, and a new newsletter variation (#16808) AAG: Backup card, fall back to VP content in case of /rewind API error. (#16867) Donations: Fix dependencies (#16892) Creative Mail: update option to lowercase (#16861) Premium Blocks: Implement the new design (#16611) Requests to Stats CSV use the blog token (#16716) Update spacing around sharing buttons to avoid no bottom margin below the customize link. (#16811) Jetpack SSO: Cleaning up the `requestNonce` API request. (#16830) Donations: Update plans when currency changes (#16844) ...
This PR changes the token used by the stats module to make a request to the
updateBlogXMLRPC endpoint. It drops the use of the "Master user" token and uses the blog token instead.Jetpack product discussion
p9dueE-1Dv-p2#comment-2838
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Open
modules/stats.phpfileAt line 25 change the
STATS_VERSIONvalue to a higher number, for example:define( 'STATS_VERSION', '10' );This will force a call to the
updateBlogendpointBrowse the admin panel. Just viewing a page is enough
Check the
stats_optionsoption on the cache site and confirm the value for theversionoption key was updated :)Now revert the change.
Undo the change to the constant value in the
stats.phpfile.On your local environment:
Proposed changelog entry for your changes: