Jetpack SSO: Cleaning up the requestNonce API request.
#16830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the nature of the authentication form, `user_id` is unknown when it's opened, and `blog_token` is always used for the request even though the code attempts to use the `user_token`. So this commit is janitorial and doesn't really affect the functionality.
sergeymitr
added
[Status] Needs Review
10 tasks
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16830 Scheduled Jetpack release: September 1, 2020. |
leogermani
approved these changes
Aug 18, 2020
Contributor
leogermani
left a comment
leogermani
left a comment
There was a problem hiding this comment.
Tested following the instructions and works as expected
leogermani
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Aug 20, 2020
* master: (23 commits) Premium Blocks: set blocks availability (#16898) Compat Package: Fix method declaration compatibility (#16900) Jetpack Dashboard: More meaningful error notices. (#16883) Connection REST API: Unit test for the `remote_authorize` request. (#16879) use blog token to request jetpack.updateBlog (#16698) Improve Story block media loading (#16663) Simplify error notices for broken connections (#16655) Use new heartbeat package (#16285) wrap-paid-block: remove component. deprecated. (#16895) Social Previews: improve preview description handling (#16889) Stats module use blog token (#16727) Form Block: add a new Consent Field, a new Newsletter setting, and a new newsletter variation (#16808) AAG: Backup card, fall back to VP content in case of /rewind API error. (#16867) Donations: Fix dependencies (#16892) Creative Mail: update option to lowercase (#16861) Premium Blocks: Implement the new design (#16611) Requests to Stats CSV use the blog token (#16716) Update spacing around sharing buttons to avoid no bottom margin below the customize link. (#16811) Jetpack SSO: Cleaning up the `requestNonce` API request. (#16830) Donations: Update plans when currency changes (#16844) ...
sergeymitr
added
[Feature] SSO
and removed
Connect Flow
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
…t. (#16830) By the nature of the authentication form, `user_id` is unknown when it's opened, and `blog_token` is always used for the request even though the code attempts to use the `user_token`. So this commit is janitorial and doesn't really affect the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
By the nature of the authentication form,
user_idis unknown when it's opened, andblog_tokenis always used for the request even though the code attempts to use theuser_token.So this commit is janitorial and doesn't really affect the functionality.
Jetpack product discussion
Part of the issue #16709
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
wp-login.phppage.jetpack_sso_noncewas created and contains the actual nonce (e.g.kps0dsn9fqmxbxlzbtd9).Proposed changelog entry for your changes:
n/a.