Requests to Stats CSV use the blog token #16716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
added
[Type] Enhancement
![test-case-reminder[bot]](https://avatars.githubusercontent.com/u/1306301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Here are some suggested test cases for this PR.
Stats
- Visit home page, make sure that page view is recorded in stats
- Visit home page in AMP view
- Visit post page in non-AMP and AMP view
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
10 tasks
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16716 Scheduled Jetpack release: September 1, 2020. |
fgiannar
approved these changes
Aug 18, 2020
Contributor
fgiannar
left a comment
fgiannar
left a comment
There was a problem hiding this comment.
LGTM
Tested with instruction and works as expected.
fgiannar
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Aug 20, 2020
* master: (23 commits) Premium Blocks: set blocks availability (#16898) Compat Package: Fix method declaration compatibility (#16900) Jetpack Dashboard: More meaningful error notices. (#16883) Connection REST API: Unit test for the `remote_authorize` request. (#16879) use blog token to request jetpack.updateBlog (#16698) Improve Story block media loading (#16663) Simplify error notices for broken connections (#16655) Use new heartbeat package (#16285) wrap-paid-block: remove component. deprecated. (#16895) Social Previews: improve preview description handling (#16889) Stats module use blog token (#16727) Form Block: add a new Consent Field, a new Newsletter setting, and a new newsletter variation (#16808) AAG: Backup card, fall back to VP content in case of /rewind API error. (#16867) Donations: Fix dependencies (#16892) Creative Mail: update option to lowercase (#16861) Premium Blocks: Implement the new design (#16611) Requests to Stats CSV use the blog token (#16716) Update spacing around sharing buttons to avoid no bottom margin below the customize link. (#16811) Jetpack SSO: Cleaning up the `requestNonce` API request. (#16830) Donations: Update plans when currency changes (#16844) ...
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the token used by the Stats module to make requests to
stats.wordpress.com/csv.php.Jetpack product discussion
Soon
Does this pull request change what data or activity we track or use?
No
Testing instructions:
First of all, you will need a connected site that has some Stats.
Let's first test it before checking out this branch, so we can compare the results
stats.wordpress.comwp option delete stats_cache(you will need to do this every time you run a test to make sure a new request is performed)Proposed changelog entry for your changes: