Connection REST API: Unit test for the remote_authorize request.
#16879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test only verifies the existence of the endpoint, and turned out to be unreliable. The test has been rewritten to actually test the authorization process. Some existing tests were also refactored.
sergeymitr
added
[Status] Needs Review
![test-case-reminder[bot]](https://avatars.githubusercontent.com/u/1306301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAMEto true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
github-actions
bot
added
the
[Status] Needs Package Release
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16879 Scheduled Jetpack release: September 1, 2020. |
kbrown9
previously approved these changes
Aug 19, 2020
kbrown9
added
[Status] Ready to Merge
Moving the assertions to the end of the tests to ensure that environment cleanup gets performed even if a test fails.
Contributor
Author
|
Thanks @kbrown9, that's a really good catch. Failing one test did lead to failing other tests too, and you end up not knowing where to look ¯\_(ツ)_/¯ |
sergeymitr
added
[Status] Needs Review
kbrown9
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Aug 20, 2020
* master: (23 commits) Premium Blocks: set blocks availability (#16898) Compat Package: Fix method declaration compatibility (#16900) Jetpack Dashboard: More meaningful error notices. (#16883) Connection REST API: Unit test for the `remote_authorize` request. (#16879) use blog token to request jetpack.updateBlog (#16698) Improve Story block media loading (#16663) Simplify error notices for broken connections (#16655) Use new heartbeat package (#16285) wrap-paid-block: remove component. deprecated. (#16895) Social Previews: improve preview description handling (#16889) Stats module use blog token (#16727) Form Block: add a new Consent Field, a new Newsletter setting, and a new newsletter variation (#16808) AAG: Backup card, fall back to VP content in case of /rewind API error. (#16867) Donations: Fix dependencies (#16892) Creative Mail: update option to lowercase (#16861) Premium Blocks: Implement the new design (#16611) Requests to Stats CSV use the blog token (#16716) Update spacing around sharing buttons to avoid no bottom margin below the customize link. (#16811) Jetpack SSO: Cleaning up the `requestNonce` API request. (#16830) Donations: Update plans when currency changes (#16844) ...
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
…ze` request. (#16879) The existing test only verifies the existence of the endpoint, and turned out to be unreliable. The test has been rewritten to actually test the authorization process. Some existing tests were also refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilding the connection package unit test
Test_REST_Endpoints::test_remote_authorize().Changes proposed in this Pull Request:
The existing test only verifies the existence of the endpoint, and turned out to be unreliable.
The test has been rewritten to actually test the authorization process. Some existing tests were also refactored.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Run unit tests for the
jetpack-connectionpackage.Make sure that all tests pass.
Proposed changelog entry for your changes:
n/a