[aspnetcore] Minor code cleanups. #2400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add custom type adapter to deserialize UUID * Update samples ./bin/kotlin-client-threetenbp.sh ./bin/kotlin-client-string.sh ./bin/kotlin-client-petstore.sh
* Add a test case of resolving inline request body * Delete legacy test case * Add a test case of resolve inline request body with required * Delete legacy test case
…penAPITools#1765) * add pet, array of array test, use CompareNetObject for comparision * add an option, should trigger ci failure * update doc * use useCompareNetObjects in csharp-refactor petstore * fix project template
* [Slim] Add PHP_CodeSniffer config template * [Slim] Update doc * [Slim] Add local configs to gitignore PHPUnit and PHP_CodeSniffer provides the same developing pattern when user overrides global config with local one. In local config he can set environment variables. Official doc recommends to not commit local config files. * [Slim] Remove phpcsStandard CLI option Now user have full freedom to override config file. This option is not used and not necessary anymore. * [Slim] Refresh samples
* Fix type inference error * Update samples bin/openapi3/kotlin-client-petstore.sh bin/kotlin-client-petstore.sh * Update samples
…ols#1772) * Add test case * Delete legacy test case * Add a test case: inline array schema * Delete legacy test case * Fix test yaml
…nAPITools#1777) * Add test case : inline array request body * Delete legacy test case * Tweak code format * Delete unused import
…Tools#1778) * Add test case : inline array response * Add test case : inline array response with title * Delete legacy test cases
* [Slim] Add encodePath method * [Slim] Add tests for encodePath method * [Slim] Use unescaped path in router Both variables basePathWithoutHost and path are already urlEncoded in codegen itself. Builtin html encoding in mustache is redundant. We can use these raw codegen values with no fear. * [Slim] Refresh samples
…enAPITools#1767) * add option to use reflection in equals, hashcode (java) * add model test template to java client only * update pestore samples * update java samples * update doc * update usage, remove unused file
…1762) * Use JsonNullable wrapper on nullable/x-nullable fields Fix OpenAPITools#1250 * update samples
* Delete unused method * Delete unused property "typeMapping" * Delete unused "import" declaration
* add nullable support to c# client (refactor) * clean up methods * move typemapping to constructor
…ls#1729) * add option to generate alias as model * fix issue due to incorrect merge
…ditionalProperties (OpenAPITools#1781) * Add test case : inline object response with additionalProperties * Delete legacy test case
* Add a test case * Fix that the inline models couldn't be flatten when "components" doesn't exist * Rename yaml file * Rename method name
…ITools#1784) * Uncomment a valid test case * Add test case : inline request body with title * Delete legacy test case * Delete unused import * Delete legacy test case which is already implemented by other test see InlineModelResolverTest#resolveInlineArrayResponseWithTitle() * Delete legacy test case which is covered by other test * Add test case : arbitraryObjectBodyParam * Delete legacy test case : testArbitraryObjectBodyParam * Add test case : arbitraryObjectRequestBodyProperty * Delete legacy test case : testArbitraryObjectBodyParamInline * Add test case : arbitraryRequestBodyArray * Delete legacy test case : testArbitraryObjectBodyParamWithArray * Add test case : arbitraryRequestBodyArrayProperty * Delete legacy test case
…ls#1785) * Add test case : arbitraryObjectResponse * Delete legacy test case : testArbitraryObjectResponse * Add test case : arbitraryObjectResponseArray * Delete legacy test case : testArbitraryObjectResponseArray * Add test case : arbitraryObjectResponseArrayInline * Delete legacy test case : testArbitraryObjectResponseArrayInline * Add test case : arbitraryObjectResponseWithAdditionalProperty * Delete legacy test case : testArbitraryObjectResponseMapInline
…#1786) * Add test case : arbitraryObjectModelInline * Delete legacy test case : testArbitraryObjectModelInline * Add test case : arbitraryObjectModelWithArrayInlineWithoutTitle * Delete legacy test case : testArbitraryObjectModelWithArrayInlineWithoutTitle * Add test case : arbitraryObjectModelWithArrayInlineWithTitle * Delete legacy test case : testArbitraryObjectModelWithArrayInlineWithTitle * Add test case : emptyExampleOnStringTypeModels * Delete legacy test case : testEmptyExampleOnStrinngTypeModels
* Delete unnecessary "throws" * Delete unnecessary cast expressions * Tweak redundant assertions * Delete unnecessary comment
* Extract a method "flattenPaths" to reduce the scope of method * Tweak * Rename parameter name * Extract a method "flattenModels" to reduce the scope of method * Rename parameter name * Rename: models -> components * Delete comment * Extract a method "flattenRequestBody" to reduce the scope of method * Extract a method "flattenParameters" to reduce the scope of method * Extract a method "flattenResponses" to reduce the scope of method * Tweak types * Reduce indentation
* Update GenerateTaskDslTest to remove "Pets" array model which is no longer generated * Ensure check on uploadArchives task
* comment out apt-get update * test php slim in travis * comment out php verison check
* add process utils to add index to properties * fix javadoc warning
…itoss/openapi-generator into feature/aspnetcore_async
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
@A-Joshi thanks for the PR but seems like the rebase fails. Do you mind filing a new PR based on the latest master by cherry-picking the commits that belong to you? |
Contributor
Author
|
will do that but do want to understand why it fails. I am doing the
following to rebase:
origin https://github.com/ihsmarkitoss/openapi-generator.git (fetch)
origin https://github.com/ihsmarkitoss/openapi-generator.git (push)
upstream https://github.com/OpenAPITools/openapi-generator.git
(fetch)
upstream https://github.com/OpenAPITools/openapi-generator.git (push)
git checkout master
git fetch upstream
git merge upstream/master
git push
git checkout feature/aspnetcore_async
git rebase master
git pull
git push
Do you see anything wrong with that?
…On 3/14/19 9:28 AM, William Cheng wrote:
@A-Joshi <https://github.com/A-Joshi> thanks for the PR but seems like
the rebase fails. Do you mind filing a new PR based on the latest
master by cherry-picking the commits that belong to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2400 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANQEIQeoNuw26juIhWwbmUyHVHWPnZ_Rks5vWk5igaJpZM4b0HwF>.
|
Contributor
Author
|
Created cleaned up new PR 2436 |
Contributor
Author
|
Created new PR with conflicts etc. cleaned up 2436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Mostly cosmetic code refactoring to make the code more readable - as per 2285