Remove dead pubsub/nats code #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it.
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 30.59% 34.23% +3.63%
==========================================
Files 85 132 +47
Lines 7148 10765 +3617
==========================================
+ Hits 2187 3685 +1498
- Misses 4724 6695 +1971
- Partials 237 385 +148
Continue to review full report at Codecov.
|
pkedy
added a commit
that referenced
this pull request
Jul 23, 2021
* Improve error message in case of missing property (#1012) Co-authored-by: Artur Souza <[email protected]> * Remove vestigial pubsub/nats code (#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. * Fixing the handling of detach errors Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Simon Leet <[email protected]>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Jul 26, 2021
# This is the 1st commit message: Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message dapr#2: Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message dapr#3: bugfix for sns topic deletion upon termination # This is the commit message dapr#4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb.
dapr-bot
pushed a commit
that referenced
this pull request
Aug 6, 2021
* Fixing the handling of detach errors (#1030) * Improve error message in case of missing property (#1012) Co-authored-by: Artur Souza <[email protected]> * Remove vestigial pubsub/nats code (#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. * Fixing the handling of detach errors Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Simon Leet <[email protected]> * Revert "Fixing the handling of detach errors (#1030)" (#1031) This reverts commit 54840c2. * Fixing the handling of detach errors (#1032) Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Simon Leet <[email protected]>
yaron2
added a commit
that referenced
this pull request
Aug 6, 2021
* bugfix for sns topic deletion upon termination * Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * wip on normalizing queue/topic names * sanitize queue and topic names * sanitized names. bugfix for close * # This is a combination of 4 commits. # This is the 1st commit message: Improve error message in case of missing property (#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message #2: Remove vestigial pubsub/nats code (#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message #3: bugfix for sns topic deletion upon termination # This is the commit message #4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * removed debug message * raw string abort * gofmt+remove regex and use byte iter Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
dapr-bot
added a commit
that referenced
this pull request
Aug 14, 2021
* bugfix for sns topic deletion upon termination * Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * wip on normalizing queue/topic names * sanitize queue and topic names * sanitized names. bugfix for close * # This is a combination of 4 commits. # This is the 1st commit message: Improve error message in case of missing property (#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message #2: Remove vestigial pubsub/nats code (#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message #3: bugfix for sns topic deletion upon termination # This is the commit message #4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * removed debug message * raw string abort * merge issues solved * wip * gofmt+remove regex and use byte iter * wip. first impl of dead-letters queue config * wip. refactor and fallback values * integration test wip * wip integration test * wip integration * wip on testing * wip * still buggy but wip! * bugfix in dlq creation * working. still bug in subscription clean up * Update snssqs_integ_test.go * golangci-lint fixes * golangci-lint refactoring * trying to skip running integrations for snssqs * testing * skip integration test if no AWS related envvars are set (skip in CI) * parallel testing in unittests * code review fixes * not using implicit maxReceives * maxReceives renamed * unittest refactor * Update snssqs.go * integ removed, renaming back of const Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Dapr Bot <[email protected]>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* Fixing the handling of detach errors (dapr#1030) * Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> * Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. * Fixing the handling of detach errors Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Simon Leet <[email protected]> * Revert "Fixing the handling of detach errors (dapr#1030)" (dapr#1031) This reverts commit 54840c2. * Fixing the handling of detach errors (dapr#1032) Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Simon Leet <[email protected]>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
…r#1035) * bugfix for sns topic deletion upon termination * Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * wip on normalizing queue/topic names * sanitize queue and topic names * sanitized names. bugfix for close * # This is a combination of 4 commits. # This is the 1st commit message: Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message dapr#2: Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message dapr#3: bugfix for sns topic deletion upon termination # This is the commit message dapr#4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * removed debug message * raw string abort * gofmt+remove regex and use byte iter Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Amit Mor <[email protected]>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* bugfix for sns topic deletion upon termination * Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * wip on normalizing queue/topic names * sanitize queue and topic names * sanitized names. bugfix for close * # This is a combination of 4 commits. # This is the 1st commit message: Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message dapr#2: Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message dapr#3: bugfix for sns topic deletion upon termination # This is the commit message dapr#4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * removed debug message * raw string abort * merge issues solved * wip * gofmt+remove regex and use byte iter * wip. first impl of dead-letters queue config * wip. refactor and fallback values * integration test wip * wip integration test * wip integration * wip on testing * wip * still buggy but wip! * bugfix in dlq creation * working. still bug in subscription clean up * Update snssqs_integ_test.go * golangci-lint fixes * golangci-lint refactoring * trying to skip running integrations for snssqs * testing * skip integration test if no AWS related envvars are set (skip in CI) * parallel testing in unittests * code review fixes * not using implicit maxReceives * maxReceives renamed * unittest refactor * Update snssqs.go * integ removed, renaming back of const Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Amit Mor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
pubsub/natscomponent was replaced bypubsub/natsstreamingas part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it.Issue reference
Finishes off work started by dapr/dapr#1996
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: