SNS and SQS topic/queue names + SNS subscription deletion bugfix #1035
Conversation
|
|
# This is the 1st commit message: Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message dapr#2: Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message dapr#3: bugfix for sns topic deletion upon termination # This is the commit message dapr#4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb.
|
/cc @pkedy |
|
lgtm |
|
hi @daixiang0 @pkedy - sorry to bother, but can you trigger the build workflows so that this PR can proceed? I've run gofmt + gofumpt as the previous builds where crashing partly due to the lack of proper formatting (In my "defense" I'd say I didn't see those as required for contribution) |
|
due to the passing of time my fork had drifted away from origin/master so I've merged it to be able to proceed with this PR. Awaiting approvers to trigger the build/test workflow |
|
@artursouza the build is failing because of Conformance Tests / state.redis |
|
hi @daixiang0 @pkedy @artursouza |
Sorry for the late response. running now. |
|
@amimimor were you able to test the component to make sure there are no regressions? |
|
Yes. I tested it several times and it’s now on our staging environment
On Fri, 6 Aug 2021 at 23:53 Yaron Schneider ***@***.***> wrote:
@amimimor <https://github.com/amimimor> were you able to test the
component to make sure there are no regressions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHL4SRQUU4K4H2KKNPK25DT3RDWNANCNFSM5A5OYIGQ>
.
--
All the best,
Amit Mor
|
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 34.03% 34.53% +0.49%
==========================================
Files 133 132 -1
Lines 10750 10870 +120
==========================================
+ Hits 3659 3754 +95
- Misses 6710 6736 +26
+ Partials 381 380 -1
Continue to review full report at Codecov.
|
…r#1035) * bugfix for sns topic deletion upon termination * Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * wip on normalizing queue/topic names * sanitize queue and topic names * sanitized names. bugfix for close * # This is a combination of 4 commits. # This is the 1st commit message: Improve error message in case of missing property (dapr#1012) Co-authored-by: Artur Souza <[email protected]> # This is the commit message dapr#2: Remove vestigial pubsub/nats code (dapr#1024) The pubsub/nats component was replaced by pubsub/natsstreaming as part of dapr/dapr#2003, but the corresponding code in dapr/components-contrib was not removed, so this change removes it. # This is the commit message dapr#3: bugfix for sns topic deletion upon termination # This is the commit message dapr#4: Revert "bugfix for sns topic deletion upon termination" This reverts commit bcaa9bb. * removed debug message * raw string abort * gofmt+remove regex and use byte iter Co-authored-by: Maarten Mulders <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Amit Mor <[email protected]>
5 participants
Description
Issue reference
#1034
#1029
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: