Skip to content

Conversation

@yaron2
Copy link
Member

@yaron2 yaron2 commented Sep 26, 2019

No description provided.

@yaron2 yaron2 merged commit 05b3489 into dapr:master Sep 26, 2019
@yaron2 yaron2 deleted the bindingstable branch September 26, 2019 23:17
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Jul 26, 2021
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.
yaron2 added a commit that referenced this pull request Aug 6, 2021
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* gofmt+remove regex and use byte iter

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
dapr-bot added a commit that referenced this pull request Aug 14, 2021
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* merge issues solved

* wip

* gofmt+remove regex and use byte iter

* wip. first impl of dead-letters queue config

* wip. refactor and fallback values

* integration test wip

* wip integration test

* wip integration

* wip on testing

* wip

* still buggy but wip!

* bugfix in dlq creation

* working. still bug in subscription clean up

* Update snssqs_integ_test.go

* golangci-lint fixes

* golangci-lint refactoring

* trying to skip running integrations for snssqs

* testing

* skip integration test if no AWS related envvars are set (skip in CI)
* parallel testing in unittests

* code review fixes

* not using implicit maxReceives
* maxReceives renamed
* unittest refactor

* Update snssqs.go

* integ removed, renaming back of const

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
beiwei30 pushed a commit to beiwei30/components-contrib that referenced this pull request Nov 25, 2021
yaron2 pushed a commit that referenced this pull request Dec 8, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const
CrazyHZM pushed a commit to CrazyHZM/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const
CrazyHZM pushed a commit to CrazyHZM/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
…r#1035)

* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* gofmt+remove regex and use byte iter

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: Amit Mor <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* merge issues solved

* wip

* gofmt+remove regex and use byte iter

* wip. first impl of dead-letters queue config

* wip. refactor and fallback values

* integration test wip

* wip integration test

* wip integration

* wip on testing

* wip

* still buggy but wip!

* bugfix in dlq creation

* working. still bug in subscription clean up

* Update snssqs_integ_test.go

* golangci-lint fixes

* golangci-lint refactoring

* trying to skip running integrations for snssqs

* testing

* skip integration test if no AWS related envvars are set (skip in CI)
* parallel testing in unittests

* code review fixes

* not using implicit maxReceives
* maxReceives renamed
* unittest refactor

* Update snssqs.go

* integ removed, renaming back of const

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: Amit Mor <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Amit Mor <[email protected]>
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Dec 12, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: jigargandhi <[email protected]>
beiwei30 pushed a commit to beiwei30/components-contrib that referenced this pull request Dec 14, 2021
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: Ian Luo <[email protected]>
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Jan 21, 2022
* bugfix for sns topic deletion upon termination

* removed upstream github workflow files

* Update snssqs.go

* dapr bot schedule

* read and append queue attributes

* unnecessary escaping in json tag

* unexporting structs

* bugfix in policy

* bugfix in policy. merged from master

* fifo suffix as const

Signed-off-by: jigargandhi <[email protected]>
berndverst pushed a commit that referenced this pull request Nov 9, 2022
Update PR 2215 with Upstream
berndverst added a commit that referenced this pull request Dec 8, 2023
passuied added a commit to passuied/components-contrib that referenced this pull request Jun 24, 2025
Signed-off-by: Patrick Assuied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant