Skip to content

add natsstreaming and complete test with go-sdk #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2020
Merged

add natsstreaming and complete test with go-sdk #2003

merged 3 commits into from
Sep 4, 2020

Conversation

@abserari
Copy link
Member

@abserari abserari commented Sep 4, 2020

Description

register the natsstreaming pubsub components to runtime

    test the pub-sub and the ack mechanism.

Issue reference

#1996

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@abserari
add natsstreaming and complete test with go-sdk
d4bfee6 
test the pub-sub and the ack mechanism.
yaron2
yaron2 requested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the existing NATS pub/sub?

@yaron2 yaron2 merged commit 4edaf3f into dapr:master Sep 4, 2020
@yaron2
Copy link
Member

yaron2 commented Sep 4, 2020

Thanks for your contribution!

@abserari abserari deleted the nats-streaming branch September 5, 2020 12:20
@abserari
Copy link
Member Author

abserari commented Sep 5, 2020

Thanks, I'm willing to get a guide to contributing more. @yaron2

CodeMonkeyLeet pushed a commit to CodeMonkeyLeet/components-contrib that referenced this pull request Jul 20, 2021
Remove vestigial pubsub/nats code
2eb2d67 
The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
CodeMonkeyLeet pushed a commit to CodeMonkeyLeet/components-contrib that referenced this pull request Jul 20, 2021
Remove vestigial pubsub/nats code
3263663 
The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
@CodeMonkeyLeet CodeMonkeyLeet mentioned this pull request Jul 20, 2021
Merged
3 tasks
yaron2 pushed a commit to dapr/components-contrib that referenced this pull request Jul 20, 2021
@CodeMonkeyLeet
Remove vestigial pubsub/nats code (#1024)
f58e0ca 
The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
pkedy added a commit to dapr/components-contrib that referenced this pull request Jul 23, 2021
@pkedy @mthmulders
@artursouza @CodeMonkeyLeet
Fixing the handling of detach errors (#1030)
54840c2 
* Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>

* Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.

* Fixing the handling of detach errors

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Simon Leet <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Jul 26, 2021
@mthmulders
# This is a combination of 4 commits.
5c9949b 
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.
dapr-bot pushed a commit to dapr/components-contrib that referenced this pull request Aug 6, 2021
@pkedy @mthmulders
@artursouza @CodeMonkeyLeet
Merge changes from Release 1.3 to master (#1038)
b73d817 
* Fixing the handling of detach errors (#1030)

* Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>

* Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.

* Fixing the handling of detach errors

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Simon Leet <[email protected]>

* Revert "Fixing the handling of detach errors (#1030)" (#1031)

This reverts commit 54840c2.

* Fixing the handling of detach errors (#1032)

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Simon Leet <[email protected]>
yaron2 added a commit to dapr/components-contrib that referenced this pull request Aug 6, 2021
@mthmulders @yaron2
SNS and SQS topic/queue names + SNS subscription deletion bugfix (#1035)
253ef85 
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* gofmt+remove regex and use byte iter

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
dapr-bot added a commit to dapr/components-contrib that referenced this pull request Aug 14, 2021
@mthmulders @artursouza @dapr-bot
pubsub/aws/snssqs to support SQS dead-letter queue (#1066)
284d744 
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* merge issues solved

* wip

* gofmt+remove regex and use byte iter

* wip. first impl of dead-letters queue config

* wip. refactor and fallback values

* integration test wip

* wip integration test

* wip integration

* wip on testing

* wip

* still buggy but wip!

* bugfix in dlq creation

* working. still bug in subscription clean up

* Update snssqs_integ_test.go

* golangci-lint fixes

* golangci-lint refactoring

* trying to skip running integrations for snssqs

* testing

* skip integration test if no AWS related envvars are set (skip in CI)
* parallel testing in unittests

* code review fixes

* not using implicit maxReceives
* maxReceives renamed
* unittest refactor

* Update snssqs.go

* integ removed, renaming back of const

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@pkedy @mthmulders
@artursouza @CodeMonkeyLeet
Merge changes from Release 1.3 to master (dapr#1038)
7d73b1f 
* Fixing the handling of detach errors (dapr#1030)

* Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>

* Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.

* Fixing the handling of detach errors

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Simon Leet <[email protected]>

* Revert "Fixing the handling of detach errors (dapr#1030)" (dapr#1031)

This reverts commit 54840c2.

* Fixing the handling of detach errors (dapr#1032)

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Simon Leet <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@mthmulders @yaron2
SNS and SQS topic/queue names + SNS subscription deletion bugfix (dap…
7551e98 
…r#1035)

* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* gofmt+remove regex and use byte iter

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: Amit Mor <[email protected]>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@mthmulders @artursouza @dapr-bot
pubsub/aws/snssqs to support SQS dead-letter queue (dapr#1066)
9810fa0 
* bugfix for sns topic deletion upon termination

* Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* wip on normalizing queue/topic names

* sanitize queue and topic names

* sanitized names. bugfix for close

* # This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (dapr#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message dapr#2:

Remove vestigial pubsub/nats code (dapr#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message dapr#3:

bugfix for sns topic deletion upon termination

# This is the commit message dapr#4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.

* removed debug message

* raw string abort

* merge issues solved

* wip

* gofmt+remove regex and use byte iter

* wip. first impl of dead-letters queue config

* wip. refactor and fallback values

* integration test wip

* wip integration test

* wip integration

* wip on testing

* wip

* still buggy but wip!

* bugfix in dlq creation

* working. still bug in subscription clean up

* Update snssqs_integ_test.go

* golangci-lint fixes

* golangci-lint refactoring

* trying to skip running integrations for snssqs

* testing

* skip integration test if no AWS related envvars are set (skip in CI)
* parallel testing in unittests

* code review fixes

* not using implicit maxReceives
* maxReceives renamed
* unittest refactor

* Update snssqs.go

* integ removed, renaming back of const

Co-authored-by: Maarten Mulders <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: Amit Mor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abserari @yaron2