Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
bcaa9bb
bugfix for sns topic deletion upon termination
Jul 23, 2021
62ac6b0
Revert "bugfix for sns topic deletion upon termination"
Jul 23, 2021
de891cf
wip on normalizing queue/topic names
Jul 23, 2021
d4d2df7
sanitize queue and topic names
Jul 24, 2021
d3e08e7
sanitized names. bugfix for close
Jul 24, 2021
5c9949b
# This is a combination of 4 commits.
mthmulders Jul 19, 2021
f300ab3
Merge branch 'sns-sqs-topics' of https://github.com/amimimor/componen…
Jul 26, 2021
408fdcd
removed debug message
Jul 26, 2021
f3bee8a
raw string abort
Jul 26, 2021
be550bf
merge issues solved
Jul 26, 2021
7b7dc93
wip
Jul 26, 2021
cb0f2e5
gofmt+remove regex and use byte iter
Jul 26, 2021
1c82e85
Merge branch 'sns-sqs-topics' into dead-letters
Jul 27, 2021
dd0c6e2
wip. first impl of dead-letters queue config
Jul 28, 2021
6c3e283
wip. refactor and fallback values
Jul 28, 2021
e38572a
Merge remote-tracking branch 'upstream/master' into dead-letters
Jul 29, 2021
b4692c9
integration test wip
Jul 29, 2021
58ad8a9
wip integration test
Jul 29, 2021
46bbbc7
wip integration
Jul 30, 2021
43b6e9e
Merge remote-tracking branch 'upstream/master' into dead-letters
Aug 1, 2021
582dfb8
Merge remote-tracking branch 'upstream/master' into dead-letters
Aug 4, 2021
3cfa704
wip on testing
Aug 4, 2021
c5301a6
Merge remote-tracking branch 'upstream/master' into dead-letters
Aug 8, 2021
aace0a1
wip
Aug 8, 2021
f36e268
still buggy but wip!
Aug 8, 2021
eaf769e
bugfix in dlq creation
Aug 8, 2021
e88ae91
working. still bug in subscription clean up
Aug 8, 2021
06c2ff2
Update snssqs_integ_test.go
Aug 9, 2021
207c203
golangci-lint fixes
Aug 9, 2021
2b29a40
golangci-lint refactoring
Aug 10, 2021
98222d9
trying to skip running integrations for snssqs
Aug 10, 2021
a4b5c26
testing
Aug 10, 2021
39ca9ba
Merge remote-tracking branch 'upstream/master' into dead-letters
Aug 12, 2021
d17746f
code review fixes
Aug 12, 2021
fc73805
Update snssqs.go
Aug 13, 2021
aca1b3e
Merge remote-tracking branch 'upstream/master' into dead-letters
Aug 13, 2021
ec5c12f
Merge branch 'master' into dead-letters
artursouza Aug 13, 2021
eba168c
integ removed, renaming back of const
Aug 13, 2021
811c4b2
Merge branch 'dead-letters' of https://github.com/amimimor/components…
Aug 13, 2021
2722455
Merge branch 'master' into dead-letters
artursouza Aug 14, 2021
8f4f6ab
Merge branch 'master' into dead-letters
dapr-bot Aug 14, 2021
e5d5b37
Merge branch 'master' into dead-letters
dapr-bot Aug 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
# This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.
  • Loading branch information
mthmulders authored and Amit Mor committed Jul 26, 2021
commit 5c9949b40a4f79afa70d54b5af19b1d941594a00
2 changes: 1 addition & 1 deletion bindings/smtp/smtp.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (s *Mailer) Invoke(req *bindings.InvokeRequest) (*bindings.InvokeResponse,
// Merge config metadata with request metadata
metadata := s.metadata.mergeWithRequestMetadata(req)
if metadata.EmailFrom == "" {
return nil, fmt.Errorf("smtp binding error: fromEmail property not supplied in configuration- or request-metadata")
return nil, fmt.Errorf("smtp binding error: emailFrom property not supplied in configuration- or request-metadata")
}
if metadata.EmailTo == "" {
return nil, fmt.Errorf("smtp binding error: emailTo property not supplied in configuration- or request-metadata")
Expand Down
11 changes: 0 additions & 11 deletions pubsub/nats/metadata.go

This file was deleted.

99 changes: 0 additions & 99 deletions pubsub/nats/nats.go

This file was deleted.

69 changes: 0 additions & 69 deletions pubsub/nats/nats_test.go

This file was deleted.