Update master #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame (#1996) * [webview_flutter] Allow underscores anywhere for Javascript Channel name
…ization (#2038) The current plugin implementation stores a reference to the rootViewController during the initialisation which breaks scenarios like app2app. This PR does not store any variable to rootViewController but search through the VC hierarchy to get the top most VC in order to present the new vc.
This PR fixes a possible NullPointerException when the device has only front-facing cameras. There are two versions of CamcorderProfile.get, the one currently in use will return null in case there is no back-facing camera. The second version uses the cameraId to avoid returning null. More: https://developer.android.com/reference/android/media/CamcorderProfile.html#get(int,%20int)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.