refactor(ast_tools): rename var #6676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Oct 19, 2024
Member
Author
github-actions
bot
added
A-ast-tools
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
from
5f35384 to
6e356e9
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_rename_var
branch
2 times, most recently
from
da37bb3 to
85443d4
Compare
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
overlookmotel
added
the
0-merge
Graphite App
Contributor
Merge activity
|
Follow-on after #6404. Pure refactor. Rename `type_def` to `ts_type_def` to clarify that it's not an instance of `TypeDef` type.
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
branch
from
6e356e9 to
11458a5
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_rename_var
branch
from
85443d4 to
59dd061
Compare
Base automatically changed from
10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches
to
main
October 19, 2024 19:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #6404. Pure refactor. Rename
type_deftots_type_defto clarify that it's not an instance ofTypeDeftype.