Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 19, 2024

Follow-on after #6404. Style nit. Add line breaks to generated code, to make it easier to read.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files branch from 467ebec to cb29f0d Compare October 19, 2024 09:33
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive branch from fcd9609 to 9068a23 Compare October 19, 2024 09:33
@overlookmotel overlookmotel changed the base branch from 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files to 10-19-refactor_ast_tools_shorten_generated_code_for_impl_serialize_ October 19, 2024 09:33
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 09:36
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6680 will not alter performance

Comparing 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive (85e69a1) with 10-19-refactor_ast_tools_shorten_generated_code_for_impl_serialize_ (ad8e293)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 19, 2024
Copy link
Member Author

overlookmotel commented Oct 19, 2024

Merge activity

  • Oct 19, 3:49 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 19, 3:49 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 19, 4:08 PM EDT: A user merged this pull request with the Graphite merge queue.

…erive (#6680)

Follow-on after #6404. Style nit. Add line breaks to generated code, to make it easier to read.
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_shorten_generated_code_for_impl_serialize_ branch from 51cacfd to ad8e293 Compare October 19, 2024 19:52
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive branch from 9068a23 to 85e69a1 Compare October 19, 2024 19:53
Base automatically changed from 10-19-refactor_ast_tools_shorten_generated_code_for_impl_serialize_ to main October 19, 2024 20:06
@graphite-app graphite-app bot merged commit 85e69a1 into main Oct 19, 2024
@graphite-app graphite-app bot deleted the 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive branch October 19, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants