Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 19, 2024

Incomplete. Not for merging.

This is some code that I pulled out of #6404 as it was dead code.

@ottomated opening this PR just so your WIP on this is not lost. I assume you'll want to build on it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 19, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6687 will not alter performance

Comparing 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file (3bac712) with main (b66ae2e)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from 103f829 to 50f771a Compare October 19, 2024 20:11
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file branch from f3bd9ff to baec32f Compare October 19, 2024 20:11
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from b45d850 to d3eb2ac Compare October 20, 2024 20:53
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file branch from baec32f to 7a087ee Compare October 20, 2024 20:53
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from d3eb2ac to b3dd45f Compare October 20, 2024 21:18
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file branch from 7a087ee to bf90659 Compare October 20, 2024 21:18
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from b3dd45f to 902a3d0 Compare October 20, 2024 21:29
Base automatically changed from 10-19-feat_ast_tools_ability_to_generate_text_files to main October 20, 2024 21:36
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file branch from bf90659 to 3792f97 Compare October 20, 2024 21:36
@overlookmotel
Copy link
Member Author

These changes are now part of #6755.

@Boshen Boshen deleted the 10-19-feat_ast_tools_generate_ts_type_defs_as_text_file branch February 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants