Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 19, 2024

Follow-on after #6404. Use double quotes in TS type defs, to match the code style wasm_bindgen uses for the types it generates.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive branch from fcd9609 to 9068a23 Compare October 19, 2024 09:33
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs branch from 6205d3a to 9ca8f75 Compare October 19, 2024 09:33
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 09:38
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6681 will not alter performance

Comparing 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs (01b9e83) with main (85e69a1)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

@ottomated ottomated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care about this? It makes the generated code harder to read and longer, plus we're not going to be using wasm-bindgen for this forever.

@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive branch from 9068a23 to 85e69a1 Compare October 19, 2024 19:53
Base automatically changed from 10-19-refactor_ast_tools_add_line_breaks_to_generated_code_for_estree_derive to main October 19, 2024 20:08
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs branch from 9ca8f75 to 01b9e83 Compare October 19, 2024 20:08
Copy link
Contributor

@rzvxa rzvxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I approved this by mistake, meant to approve #6685

@overlookmotel
Copy link
Member Author

Do we care about this? It makes the generated code harder to read and longer, plus we're not going to be using wasm-bindgen for this forever.

Fair point!

@Boshen Boshen deleted the 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs branch February 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants