Skip to content

refactor(ast_tools): pass Codegen to prepare methods #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 17, 2025
Merged

refactor(ast_tools): pass Codegen to prepare methods #9818

graphite-app merged 1 commit into from
Mar 17, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 17, 2025 •
edited
Loading

Pure refactor. In oxc_ast_tools, pass &Codegen to prepare method of Derives and Generators. This is preparation for changes to come to ESTree generator.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Mar 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 17, 2025
This was referenced Mar 17, 2025
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 17, 2025 07:32
@overlookmotel overlookmotel force-pushed the 03-17-refactor_ast_tools_pass_codegen_to_prepare_methods branch from bfc6577 to bbc6db1 Compare March 17, 2025 07:37
@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 17, 2025

Pure refactor, and does not alter generated output, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 17, 4:19 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 17, 4:19 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 17, 4:24 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
refactor(ast_tools): pass Codegen to prepare methods (#9818)
0d33ba3 
Pure refactor. In `oxc_ast_tools`, pass `&Codegen` to `prepare` method of `Derive`s and `Generator`s. This is preparation for changes to come to `ESTree` generator.
@graphite-app graphite-app bot force-pushed the 03-17-refactor_ast_tools_pass_codegen_to_prepare_methods branch from bbc6db1 to 0d33ba3 Compare March 17, 2025 08:19
@graphite-app graphite-app bot merged commit 0d33ba3 into main Mar 17, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 03-17-refactor_ast_tools_pass_codegen_to_prepare_methods branch March 17, 2025 08:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel