feat(ast_tools/estree): check no repeated field names in #[estree(field_order)] attrs
#9819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-ast-tools
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 17, 2025
overlookmotel
force-pushed
the
03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs
branch
from
6b17311 to
5d97367
Compare
overlookmotel
force-pushed
the
03-17-refactor_ast_tools_pass_codegen_to_prepare_methods
branch
from
bfc6577 to
bbc6db1
Compare
Member
Author
|
Pure refactor, so merging without review. |
graphite-app
bot
changed the base branch from
03-17-refactor_ast_tools_pass_codegen_to_prepare_methods
to
graphite-base/9819
Member
Author
Merge activity
|
…eld_order)]` attrs (#9819) `ESTree` generator error if same field name is repeated twice in an `#[estree(field_order(...))]` attribute.
graphite-app
bot
force-pushed
the
03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs
branch
from
5d97367 to
158cdb9
Compare
graphite-app
bot
deleted the
03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESTreegenerator error if same field name is repeated twice in an#[estree(field_order(...))]attribute.