Skip to content

feat(ast/estree): order TS fields last by default #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 17, 2025
Merged

feat(ast/estree): order TS fields last by default #9820

graphite-app merged 1 commit into from
Mar 17, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 17, 2025 •
edited
Loading

ESTree generator order fields marked #[ts] last by default. This behavior can be overridden if required with #[estree(field_order)].

@overlookmotel overlookmotel mentioned this pull request Mar 17, 2025
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 17, 2025
Merged
Merged
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Mar 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 17, 2025 07:35
@overlookmotel overlookmotel force-pushed the 03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs branch from 6b17311 to 5d97367 Compare March 17, 2025 07:37
@overlookmotel overlookmotel force-pushed the 03-17-feat_ast_estree_order_ts_fields_last_by_default branch from 3b6899b to 182da49 Compare March 17, 2025 07:37
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9820 will not alter performance

Comparing 03-17-feat_ast_estree_order_ts_fields_last_by_default (db946e6) with main (7da3124)

Summary

✅ 33 untouched benchmarks

@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 17, 2025

Only affects order of fields in ESTree-TS AST, not their content. So merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 17, 4:20 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 17, 4:20 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 17, 4:33 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
feat(ast/estree): order TS fields last by default (#9820)
db946e6 
`ESTree` generator order fields marked `#[ts]` last by default. This behavior can be overridden if required with `#[estree(field_order)]`.
@graphite-app graphite-app bot force-pushed the 03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs branch from 5d97367 to 158cdb9 Compare March 17, 2025 08:26
@graphite-app graphite-app bot force-pushed the 03-17-feat_ast_estree_order_ts_fields_last_by_default branch from 182da49 to db946e6 Compare March 17, 2025 08:27
Base automatically changed from 03-17-feat_ast_tools_estree_check_no_repeated_field_names_in_estree_field_order_attrs to main March 17, 2025 08:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
@graphite-app graphite-app bot merged commit db946e6 into main Mar 17, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-17-feat_ast_estree_order_ts_fields_last_by_default branch March 17, 2025 08:33
@overlookmotel overlookmotel mentioned this pull request Mar 17, 2025
Closed
@oxc-bot oxc-bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel