-
-
Notifications
You must be signed in to change notification settings - Fork 775
refactor(ast)!: reorder fields of TemplateElement
#9821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast)!: reorder fields of TemplateElement
#9821
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
f935178 to
118a88a
Compare
3b6899b to
182da49
Compare
CodSpeed Performance ReportMerging #9821 will not alter performanceComparing Summary
|
|
@Boshen Just checking it's not a big problem to make small changes to AST like this? It is a breaking change as it alters the order of params to We don't have to make this change - ESTree serialization was working fine already. It's just a bit of "tidy up". |
118a88a to
7838c35
Compare
182da49 to
db946e6
Compare
7838c35 to
e99a27a
Compare

Re-order the fields of
TemplateElement, movingtailto last. This means fields are in same order as ESTree, withou having to manually re-order them.The field order makes no real difference here, since
tailfield is not visited, so I figure might as well align with ESTree.