This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactor/substrate state machine generic #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bstrate-state-machine-generic * refactor/environmental-generic-traits: whitespace Teach environmental! about generics Validator side of the collation protocol. (#295) Improve Wasm extern errors and increase heap (#299) Issue 212 - refactor Checkable trait to be more generic (#287) Fix for nightly 2018-07-10 (#296) PoC-2 tweaks (#293)
Remove unused U512 Add test to ensure H256 impls heapsizeof
* master: (86 commits) Make contract a separate runtime module (#345) Version bump (#450) DB-based blockchain data cache for light nodes (#251) Update libp2p again (#445) Update version on git head change (#444) Fix the public key of bootnode 3 (#441) Update libp2p (#442) Switch to the master branch of libp2p (#427) Export ws port 9944 and add doc (#440) Iterate over overlay to decide which keys to purge (#436) Exit signal gets its own trait (#433) Add docker image (#375) Reset peers.json if the content is not loadable (#405) Limit number of incoming connections (#391) Fix memory leaks in libp2p (#432) Do not queue empty blocks set for import (#431) 5 random fixes (#1) (#435) Chore: fix typo (#434) Prevent building invalid blocks (#430) Better logging for public key mismatch (#429) ...
Use rlp from master so dependencies do not mess up the scope
* master: Collator for the "adder" (formerly basic-add) parachain and various small fixes (#438) Storage changes subscription (#464) Wasm execution optimizations (#466) Fix the --key generation (#475) Fix typo in service.rs (#472) Fix session phase in early-exit (#453) Make ping unidirectional (#458) Update README.adoc
* master: Less verbosity (#546) Fetching storage proofs by light client (#252) Gitlab CI build file for linux. (#552) Vote out offline authorities (#524) fix block body fetch for availability pruning (#539) Continue sync after ancestry search (#538) Docs Typo Fixes (#534) don't wait for all futures to resolve before shutdown (#536) Update libp2p and some log (#532) Mh public key for telemetry (#526) Td bps (#527) Reserved peers CLI flag (#528)
dvdplm
added
A3-in_progress
dvdplm
added
A0-please_review
rphmeier
reviewed
Aug 15, 2018
| let result = if len == 0 { | ||
| keccak256(&[0u8; 0]) | ||
| } else { | ||
| keccak256(&this.memory.get(data, len as usize).map_err(|_| UserError("Invalid attempt to get data in ext_keccak256"))?) |
Contributor
There was a problem hiding this comment.
unfortunate that we have to reallocate the data from memory. but it's a limitation of WASM AFAIK now
rphmeier
added
A8-looksgood
and removed
A0-please_review
rphmeier
previously approved these changes
Aug 15, 2018
rphmeier
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of #297 with Keccak flavoured
HasherandRlpCodec.