Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The correct version would have been __cpp_nontype_template_args >= 201911L. All supported compilers fulfil this.
eseiler
force-pushed
the
feature/clang
branch
from
66937c5 to
45ef361
Compare
seqan-actions
added
lint
eseiler
force-pushed
the
feature/clang
branch
from
45ef361 to
91b5623
Compare
seqan-actions
added
lint
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3195 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 269 269
Lines 11861 11855 -6
==========================================
- Hits 11641 11635 -6
Misses 220 220
☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
feature/clang
branch
from
91b5623 to
ae5be12
Compare
seqan-actions
added
lint
SGSSGene
reviewed
Sep 29, 2023
SGSSGene
reviewed
Sep 29, 2023
| { | ||
| using alternative_predicate = detail::weakly_equality_comparable_with_<indirect_alternative_type>; | ||
| constexpr auto alternative_position = | ||
| constexpr bool alternative_position = |
Contributor
There was a problem hiding this comment.
This looks suspicious. isn't alternative_position holding the position?
Member
Author
There was a problem hiding this comment.
Yes, good catch. That was a search/replace error when changing the return type of two operators from auto .... -> bool to bool :)
SGSSGene
requested changes
Sep 29, 2023
Contributor
SGSSGene
left a comment
SGSSGene
left a comment
There was a problem hiding this comment.
There is one line I am not sure about correctness.
Clang in CPP20 mode emits bogus warnings for seqan3::pod_tuple
overloaded <</>> has higher precedence than ==
gcc11 complains suddenly
mutable refers to the capture
eseiler
force-pushed
the
feature/clang
branch
from
ae5be12 to
62392a1
Compare
seqan-actions
added
lint
SGSSGene
approved these changes
Sep 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.