[FIX] explicit ctor/assign is implicitly deleted

include/seqan3/argument_parser/argument_parser.hpp

@@ -150,11 +150,11 @@ class argument_parser
     /*!\name Constructors, destructor and assignment
      * \{
      */
-    argument_parser() = delete;                                     //!< Deleted.
-    argument_parser(argument_parser const &) = default;             //!< Defaulted.
-    argument_parser & operator=(argument_parser const &) = default; //!< Defaulted.
-    argument_parser(argument_parser &&) = default;                  //!< Defaulted.
-    argument_parser & operator=(argument_parser &&) = default;      //!< Defaulted.
+    argument_parser() = delete;                                    //!< Deleted.
+    argument_parser(argument_parser const &) = delete;             //!< Deleted. Holds std::future.
+    argument_parser & operator=(argument_parser const &) = delete; //!< Deleted. Holds std::future.
+    argument_parser(argument_parser &&) = default;                 //!< Defaulted.
+    argument_parser & operator=(argument_parser &&) = default;     //!< Defaulted.
 
     /*!\brief Initializes an seqan3::argument_parser object from the command line arguments.
      *

include/seqan3/core/algorithm/detail/execution_handler_parallel.hpp

@@ -213,14 +213,14 @@ class execution_handler_parallel
     {
     public:
         /*!\name Constructors, destructor and assignment
-        * \brief Instances of this class are not copyable.
+        * \brief Instances of this class are not copyable and not movable.
         * \{
         */
         internal_state() = default;                                  //!< Defaulted.
         internal_state(internal_state const &) = delete;             //!< Deleted.
-        internal_state(internal_state &&) = default;                 //!< Defaulted.
+        internal_state(internal_state &&) = delete;                  //!< Deleted.
         internal_state & operator=(internal_state const &) = delete; //!< Deleted.
-        internal_state & operator=(internal_state &&) = default;     //!< Defaulted.
+        internal_state & operator=(internal_state &&) = delete;      //!< Deleted.
 
         //!\brief Waits for threads to finish.
         ~internal_state()

include/seqan3/io/sam_file/format_sam.hpp

@@ -111,12 +111,12 @@ class format_sam : protected detail::format_sam_base
      * \{
      */
     // construction cannot be noexcept because this class has a std::string variable as a quality string buffer.
-    format_sam() = default;                               //!< Defaulted.
-    format_sam(format_sam const &) = default;             //!< Defaulted.
-    format_sam & operator=(format_sam const &) = default; //!< Defaulted.
-    format_sam(format_sam &&) = default;                  //!< Defaulted.
-    format_sam & operator=(format_sam &&) = default;      //!< Defaulted.
-    ~format_sam() = default;                              //!< Defaulted.
+    format_sam() = default;                              //!< Defaulted.
+    format_sam(format_sam const &) = delete;             //!< Deleted. Header holds a unique_ptr.
+    format_sam & operator=(format_sam const &) = delete; //!< Deleted. Header holds a unique_ptr.
+    format_sam(format_sam &&) = default;                 //!< Defaulted.
+    format_sam & operator=(format_sam &&) = default;     //!< Defaulted.
+    ~format_sam() = default;                             //!< Defaulted.
 
     //!\}
 
@@ -224,9 +224,6 @@ class format_sam : protected detail::format_sam_base
     //!\brief The default header for the alignment format.
     sam_file_header<> default_header{};
 
-    //!\brief Tracks whether reference information (\@SR tag) were found in the SAM header
-    bool ref_info_present_in_header{false};
-
     //!\brief A buffer to store a raw record pointing into the stream buffer of the input.
     std::array<std::string_view, 11> raw_record{};
 

include/seqan3/io/sam_file/header.hpp

@@ -51,18 +51,12 @@ class sam_file_header
     /*!\name Constructors, destructor and assignment
      * \{
      */
-    //!\brief Default constructor is defaulted.
-    sam_file_header() = default;
-    //!\brief Copy construction is defaulted.
-    sam_file_header(sam_file_header const &) = default;
-    //!\brief Copy assignment is defaulted.
-    sam_file_header & operator=(sam_file_header const &) = default;
-    //!\brief Move construction is defaulted.
-    sam_file_header(sam_file_header &&) = default;
-    //!\brief Move assignment is defaulted.
-    sam_file_header & operator=(sam_file_header &&) = default;
-    //!\brief Destructor is defaulted.
-    ~sam_file_header() = default;
+    sam_file_header() = default;                                   //!< Defaulted.
+    sam_file_header(sam_file_header const &) = delete;             //!< Deleted. Holds a unique_ptr.
+    sam_file_header & operator=(sam_file_header const &) = delete; //!< Deleted. Holds a unique_ptr.
+    sam_file_header(sam_file_header &&) = default;                 //!< Defaulted.
+    sam_file_header & operator=(sam_file_header &&) = default;     //!< Defaulted.
+    ~sam_file_header() = default;                                  //!< Defaulted.
 
     /*!\brief Construct from a range of reference ids which redirects the `ref_ids_ptr` member (non-owning).
      * \param[in] ref_ids The range over reference ids to redirect the pointer at.

include/seqan3/utility/parallel/detail/reader_writer_manager.hpp

@@ -80,11 +80,11 @@ class reader_writer_manager
          * \brief Not default constructible nor copyable or movable.
          * \{
          */
-        scoped_writer_type() = delete;                                        //!< Deleted.
-        scoped_writer_type(scoped_writer_type const &) = default;             //!< Deleted.
-        scoped_writer_type(scoped_writer_type &&) = default;                  //!< Defaulted.
-        scoped_writer_type & operator=(scoped_writer_type const &) = default; //!< Deleted.
-        scoped_writer_type & operator=(scoped_writer_type &&) = default;      //!< Defaulted.
+        scoped_writer_type() = delete;                                       //!< Deleted.
+        scoped_writer_type(scoped_writer_type const &) = default;            //!< Deleted.
+        scoped_writer_type(scoped_writer_type &&) = default;                 //!< Defaulted.
+        scoped_writer_type & operator=(scoped_writer_type const &) = delete; //!< Deleted. Class holds a reference.
+        scoped_writer_type & operator=(scoped_writer_type &&) = delete;      //!< Deleted. Class holds a reference.
 
         /*!\brief Constructs the scoped writer with the associated manager.
          * \param _manager The seqan3::detail::reader_writer_manager.
@@ -110,11 +110,11 @@ class reader_writer_manager
         /*!\name Constructors, destructor and assignment
          * \{
          */
-        scoped_reader_type() = delete;                                        //!< Deleted.
-        scoped_reader_type(scoped_reader_type const &) = default;             //!< Deleted.
-        scoped_reader_type(scoped_reader_type &&) = default;                  //!< Defaulted.
-        scoped_reader_type & operator=(scoped_reader_type const &) = default; //!< Deleted.
-        scoped_reader_type & operator=(scoped_reader_type &&) = default;      //!< Defaulted.
+        scoped_reader_type() = delete;                                       //!< Deleted.
+        scoped_reader_type(scoped_reader_type const &) = default;            //!< Deleted.
+        scoped_reader_type(scoped_reader_type &&) = default;                 //!< Defaulted.
+        scoped_reader_type & operator=(scoped_reader_type const &) = delete; //!< Deleted. Class holds a reference.
+        scoped_reader_type & operator=(scoped_reader_type &&) = delete;      //!< Deleted. Class holds a reference.
 
         /*!\brief Constructs the scoped reader with the associated manager.
          * \param _manager The seqan3::detail::reader_writer_manager.