Skip to content

[FEATURE] Clang support #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eseiler merged 21 commits into from
Sep 29, 2023
Merged

[FEATURE] Clang support #3195

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
909247c
[FIX] Remove __cpp_nontype_template_parameter_class
eseiler Sep 28, 2023
a8f17b4
[FIX] Unused variables
eseiler Sep 28, 2023
fcaeab2
[FIX] Ambiguous function call
eseiler Sep 28, 2023
1dc6c27
[FIX] explicit ctor/assign is implicitly deleted
eseiler Sep 28, 2023
5ba6a51
[FIX] Missing check for include
eseiler Sep 28, 2023
19b2ff6
[FIX] cvtsi64x is deprecated
eseiler Sep 28, 2023
92380a1
[FIX] Workaround clang __builtin_constant_p
eseiler Sep 28, 2023
fe386b2
[FIX] Constraint/template differs in redeclaration
eseiler Sep 28, 2023
a3304ab
[FIX] Mismatched tags (class/struct)
eseiler Sep 28, 2023
1baf50f
[FIX] Member might not be default initializable
eseiler Sep 28, 2023
5040fc5
[FIX] Workaround clang span alphabet_variant
eseiler Sep 28, 2023
9fa8e39
[FIX] Parentheses in requires
eseiler Sep 28, 2023
362ee37
[FIX] Comparison of repeat_view
eseiler Sep 28, 2023
87fec13
[FIX] Cyclic requires
eseiler Sep 28, 2023
24a3fa1
[FIX] Workaround cpp23+clang tuple weirdness
eseiler Sep 28, 2023
13c900d
[FIX] Braces around scalar initializer
eseiler Sep 28, 2023
923fc7d
[FIX] Operator precedence
eseiler Sep 28, 2023
ea9956b
[INFRA] CMake
eseiler Sep 28, 2023
dfba50b
[INFRA] CI
eseiler Sep 28, 2023
64dc64b
[FIX] Change constexpr test
eseiler Sep 28, 2023
62392a1
[FIX] take_until_view_test
eseiler Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FIX] Cyclic requires
  • Loading branch information
@eseiler
eseiler committed Sep 29, 2023
commit 87fec13850d03a27ef8e1f9ff9893e37f06aaa3a
10 changes: 6 additions & 4 deletions include/seqan3/alphabet/composite/semialphabet_any.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ class semialphabet_any : public alphabet_base<semialphabet_any<size>, size, void
* \details
* \stableapi{Since version 3.1.}
*/
template <semialphabet other_alph_t>
requires (alphabet_size<other_alph_t> == size)
template <typename other_alph_t>
requires (!std::same_as<other_alph_t, semialphabet_any>)
&& semialphabet<other_alph_t> && (alphabet_size<other_alph_t> == size)
explicit semialphabet_any(other_alph_t const other)
{
assign_rank(seqan3::to_rank(other));
Expand All @@ -83,8 +84,9 @@ class semialphabet_any : public alphabet_base<semialphabet_any<size>, size, void
* \details
* \stableapi{Since version 3.1.}
*/
template <semialphabet other_alph_t>
requires ((alphabet_size<other_alph_t> == size) && std::regular<other_alph_t>)
template <typename other_alph_t>
requires (!std::same_as<other_alph_t, semialphabet_any>)
&& semialphabet<other_alph_t> && (alphabet_size<other_alph_t> == size) && std::regular<other_alph_t>
explicit operator other_alph_t() const
{
other_alph_t other{};
Expand Down