Skip to content

[FEATURE] Clang support #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eseiler merged 21 commits into from
Sep 29, 2023
Merged

[FEATURE] Clang support #3195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
909247c
[FIX] Remove __cpp_nontype_template_parameter_class
eseiler Sep 28, 2023
a8f17b4
[FIX] Unused variables
eseiler Sep 28, 2023
fcaeab2
[FIX] Ambiguous function call
eseiler Sep 28, 2023
1dc6c27
[FIX] explicit ctor/assign is implicitly deleted
eseiler Sep 28, 2023
5ba6a51
[FIX] Missing check for include
eseiler Sep 28, 2023
19b2ff6
[FIX] cvtsi64x is deprecated
eseiler Sep 28, 2023
92380a1
[FIX] Workaround clang __builtin_constant_p
eseiler Sep 28, 2023
fe386b2
[FIX] Constraint/template differs in redeclaration
eseiler Sep 28, 2023
a3304ab
[FIX] Mismatched tags (class/struct)
eseiler Sep 28, 2023
1baf50f
[FIX] Member might not be default initializable
eseiler Sep 28, 2023
5040fc5
[FIX] Workaround clang span alphabet_variant
eseiler Sep 28, 2023
9fa8e39
[FIX] Parentheses in requires
eseiler Sep 28, 2023
362ee37
[FIX] Comparison of repeat_view
eseiler Sep 28, 2023
87fec13
[FIX] Cyclic requires
eseiler Sep 28, 2023
24a3fa1
[FIX] Workaround cpp23+clang tuple weirdness
eseiler Sep 28, 2023
13c900d
[FIX] Braces around scalar initializer
eseiler Sep 28, 2023
923fc7d
[FIX] Operator precedence
eseiler Sep 28, 2023
ea9956b
[INFRA] CMake
eseiler Sep 28, 2023
dfba50b
[INFRA] CI
eseiler Sep 28, 2023
64dc64b
[FIX] Change constexpr test
eseiler Sep 28, 2023
62392a1
[FIX] take_until_view_test
eseiler Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[INFRA] CMake
  • Loading branch information
@eseiler
eseiler committed Sep 29, 2023
commit ea9956bfb26e9f25c8778558105e334dbf570baa
12 changes: 2 additions & 10 deletions build_system/seqan3-config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,16 +196,8 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VER
message (FATAL_ERROR "GCC < 10 is not supported. The detected compiler version is ${CMAKE_CXX_COMPILER_VERSION}.")
endif ()

option (SEQAN3_DISABLE_COMPILER_CHECK "Skips the check for supported compilers." OFF)

if (NOT SEQAN3_DISABLE_COMPILER_CHECK)
if (NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
message (FATAL_ERROR "Only GCC is supported. "
"The detected compiler version is ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION}. "
"You can disable this error by passing -DSEQAN3_DISABLE_COMPILER_CHECK=ON to CMake.")
endif ()
else ()
set (SEQAN3_DEFINITIONS ${SEQAN3_DEFINITIONS} "-DSEQAN3_DISABLE_COMPILER_CHECK")
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 17)
message (FATAL_ERROR "Clang < 17 is not supported. The detected compiler version is ${CMAKE_CXX_COMPILER_VERSION}.")
endif ()

# ----------------------------------------------------------------------------
Expand Down
12 changes: 10 additions & 2 deletions include/seqan3/core/platform.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,21 @@
# endif // (__GNUC__ > 13)
# endif // SEQAN3_DISABLE_NEWER_COMPILER_DIAGNOSTIC

// ============================================================================
// Compiler support Clang
// ============================================================================

#elif defined(__clang__)
# if __clang_major__ < 17
# error "Only Clang >= 17 is supported."
# endif

// ============================================================================
// Compiler support other
// ============================================================================

#elif !defined(SEQAN3_DISABLE_COMPILER_CHECK)
# error \
"Your compiler is not supported. Currently, only GCC is known to work. You can disable this error by setting -DSEQAN3_DISABLE_COMPILER_CHECK."
# error "Your compiler is not supported. You can disable this error by setting -DSEQAN3_DISABLE_COMPILER_CHECK."
#endif // SEQAN3_COMPILER_IS_GCC

// ============================================================================
Expand Down