Skip to content

Mark the current transition effect option (#365) - #369

Merged
h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
NikitkaRa:fix/365-transition-option-highlight
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
NikitkaRa:fix/365-transition-option-highlight

Conversation

@NikitkaRa

@NikitkaRa NikitkaRa commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Transitions ▸ Effect Options and Animations ▸ Effect Options mark the choice stored on the slide, including an animation's text build (As One Object / By Paragraph).
  • Choosing an option closes the menu.
  • One helper decides the marked row for both menus, so a stored id is the only highlighted row.

Test plan

  • cargo test -p deckcraft-ui-egui --lib effect_options_mark_only_the_stored_choice
  • cargo clippy -p deckcraft-ui-egui --all-targets -- -D warnings
  • Open Transitions, set Push, open Effect Options: the current direction is highlighted.
  • Select a shape with Fly In, open Animations ▸ Effect Options: the current direction and text build are highlighted.

Fixes #365

Nikitkao and others added 2 commits October 13, 2026 12:48
The Effect Options menu drew every direction as the same button, so the active one was invisible.

Co-authored-by: Cursor <cursoragent@cursor.com>
)

The same rule that highlights a transition direction now highlights an animation's direction and text build.

Co-authored-by: Cursor <cursoragent@cursor.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 822c8f4 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
… on land-r5 (#644 #652 #655 #702 #571 #539 #674 #648 #697 #479 #369 #368)

# Conflicts:
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/ribbon.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…hs) (storytold#403)

Add text wrote Arabic as "?" (standard-14 fonts, WinAnsi). Items with
Arabic are now shaped with the craft-fonts Arab face through harfrust
(already in the tree via egui) and laid out line by line in display
order with unicode-bidi (UAX storytold#9), so Arabic mixed with Latin, digits and
brackets reads correctly. Each cluster (a letter with its dots or marks)
is one glyph of a Type 3 font drawn from the face's outlines, with a
ToUnicode entry, so text extraction, copy and search get every letter
once and no font file is embedded.

- fonts: shape_arabic / arabic_glyph / arabic_has / document_arabic_font;
  japanese_glyph's bounded outline code is shared as bounded_outline.
- edit: draw_arabic and type3_arabic; wrapping measures shaped words.
  Fonts get names free on the page (a full save renumbers objects, not
  resource names) and are removed when the item is updated or deleted.
  Outlines are read before anything is written.
- Without the face, adding Arabic is a clear error that changes nothing;
  an existing item holding Arabic still moves, drawn as "?" as before.
- Non-Arabic items are drawn exactly as before.

Refs storytold#250, storytold#280, storytold#369.

Co-authored-by: fares <aw674860@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Highlight the selected Transition Effect Option

4 participants