Skip to content

UI: Format Shape fill transparency follows the selection - #697

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/fill-transparency-selection-b770
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/fill-transparency-selection-b770

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • The Format Shape Fill transparency slider always opened at 0% and wrote that value when it lost focus, so a solid fill that was already transparent looked opaque and could be cleared just by leaving the control.
  • It now reads the selected shape's solid-fill alpha (the same transform shape.fill writes) and applies a new transparency only when the slider moves. Switching shapes does not keep the previous percent.
  • No new engine command (count stays 226). Breadth stays 79%.

Test plan

  • solid_fill_transparency_reads_the_alpha_shape_fill_writes and fill_transparency_slider_follows_the_selection in deckcraft-ui-egui
  • cargo fmt, cargo clippy, workspace tests apart from the three known macOS environment failures, cargo xtask assets, layers, wasm
  • macOS sample deck: a 40% transparent shape shows 40%, leaving the control keeps alpha 60000, moving the slider to 74% stores alpha 26000

The Fill slider seeded itself at 0% and wrote that when it lost focus, so a
solid fill that was already transparent opened as opaque and could be cleared.

Co-authored-by: Cursor <cursoragent@cursor.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 4416bc1 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
… on land-r5 (#644 #652 #655 #702 #571 #539 #674 #648 #697 #479 #369 #368)

# Conflicts:
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/ribbon.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants