Skip to content

Show: presenter view keeps a portrait Next slide inside its column - #655

Merged
h-a-n-a-s-h-i merged 3 commits into
storytold:mainfrom
NikitkaRa:fix/portrait-show
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 3 commits into
storytold:mainfrom
NikitkaRa:fix/portrait-show

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Stacked on #652, which is itself stacked on #644. The only new commit here is the last one. No issue: I found this while checking the presenter view render for #652.

Summary

  • The bug: presenter view sized the "Next" preview to the full width of its column, with the height set by the slide's aspect ratio. A portrait slide (design.slideSize allows down to 1:56) therefore drew a white slab many times the window's height. It covered the column and pushed the speaker notes below the window.
  • The fix: next_rect fits the preview into the top 60% of the column, keeping the slide's shape. 16:9 slides still take the full column width, so the usual layout doesn't change.
  • Not a bug: the main show and the "current slide" preview already handled portrait slides correctly. The landscape preview I mentioned on UI: keep every texture within the GPU max texture side #652 was a test-screenshot mix-up: the image came from the 16:9 test.

Test plan

  • texture_limit_tests::presenter_view_keeps_a_portrait_next_slide_in_its_column: harness render; the column below the preview stays dark. It was white before.
  • show::tests::the_next_preview_fits_its_column_whatever_the_slide_shape: tall, wide and 16:9 slides fit the column and keep their aspect; 16:9 keeps the full width.
  • I checked the presenter view render by eye: a narrow Next strip, with the notes visible below it.
  • cargo xtask ci: all 6 steps pass.

Overlap: #646 and #649 also edit presenter_window, but they don't change these lines (only context). If one of them merges first, expect at most a trivial rebase.

Parity checklist: this matches PowerPoint, which letterboxes the Next preview. No new rows.

NikitkaRa and others added 3 commits October 14, 2026 03:27
… small texture limits

- ui.json / prefs.json are read through a new settings module: regular files only, 4 MiB
  cap, parse errors logged, values sanitized (a saved zoom of 1e30 aborted start-up,
  1e4 panicked in egui); writes are atomic.
- The canvas and the control protocol clamp stray zooms; the status bar shows the zoom in use.
- The canvas texture is cut to the GPU's max texture side (zoom 400% on a 2048 limit panicked).
- The system font scan opens only regular files of sane size (a FIFO named *.ttf in ~/.fonts
  hung start-up), with depth and entry caps.
- AutoRecover skips non-regular entries and reopens at most 32 per start, newest first.

Co-authored-by: Cursor <cursoragent@cursor.com>
Slide show, transition and morph frames, thumbnails, master-view canvas, master/layout
thumbnails, Design Ideas previews, presenter-view preview and video frames all upload through
textures::upload/replace, which shrinks a picture past max_texture_side (egui panicked on one).
Render sizes are fitted to the limit first, so a big screen, extreme DPI or a 1:56 slide
doesn't render a picture the GPU can't hold. The master canvas is cropped like the slide canvas.

Co-authored-by: Cursor <cursoragent@cursor.com>
The Next preview took the column's full width and the slide's aspect for its height, so a
portrait slide (up to 1:56) drew a white slab many times the window's height over the notes,
which were pushed below the window. It is now fitted into the top 60% of the column; 16:9
slides keep the full width as before.

Co-authored-by: Cursor <cursoragent@cursor.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit c3489d6 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
… on land-r5 (#644 #652 #655 #702 #571 #539 #674 #648 #697 #479 #369 #368)

# Conflicts:
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/ribbon.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…e dark theme (storytold#655) (storytold#734)

* Text editor on the page keeps a dark caret on its white box in the dark theme (storytold#655)

* Form fields, typed fill text and added text keep a dark caret on their white boxes in the dark theme (storytold#655)

---------

Co-authored-by: Brandon Thomas <echelon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants