Repository navigation
Show: presenter view keeps a portrait Next slide inside its column - #655
Merged
Merged
Conversation
… small texture limits - ui.json / prefs.json are read through a new settings module: regular files only, 4 MiB cap, parse errors logged, values sanitized (a saved zoom of 1e30 aborted start-up, 1e4 panicked in egui); writes are atomic. - The canvas and the control protocol clamp stray zooms; the status bar shows the zoom in use. - The canvas texture is cut to the GPU's max texture side (zoom 400% on a 2048 limit panicked). - The system font scan opens only regular files of sane size (a FIFO named *.ttf in ~/.fonts hung start-up), with depth and entry caps. - AutoRecover skips non-regular entries and reopens at most 32 per start, newest first. Co-authored-by: Cursor <cursoragent@cursor.com>
Slide show, transition and morph frames, thumbnails, master-view canvas, master/layout thumbnails, Design Ideas previews, presenter-view preview and video frames all upload through textures::upload/replace, which shrinks a picture past max_texture_side (egui panicked on one). Render sizes are fitted to the limit first, so a big screen, extreme DPI or a 1:56 slide doesn't render a picture the GPU can't hold. The master canvas is cropped like the slide canvas. Co-authored-by: Cursor <cursoragent@cursor.com>
The Next preview took the column's full width and the slide's aspect for its height, so a portrait slide (up to 1:56) drew a white slab many times the window's height over the notes, which were pushed below the window. It is now fitted into the top 60% of the column; 16:9 slides keep the full width as before. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 14, 2026
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…e dark theme (storytold#655) (storytold#734) * Text editor on the page keeps a dark caret on its white box in the dark theme (storytold#655) * Form fields, typed fill text and added text keep a dark caret on their white boxes in the dark theme (storytold#655) --------- Co-authored-by: Brandon Thomas <echelon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #652, which is itself stacked on #644. The only new commit here is the last one. No issue: I found this while checking the presenter view render for #652.
Summary
design.slideSizeallows down to 1:56) therefore drew a white slab many times the window's height. It covered the column and pushed the speaker notes below the window.next_rectfits the preview into the top 60% of the column, keeping the slide's shape. 16:9 slides still take the full column width, so the usual layout doesn't change.Test plan
texture_limit_tests::presenter_view_keeps_a_portrait_next_slide_in_its_column: harness render; the column below the preview stays dark. It was white before.show::tests::the_next_preview_fits_its_column_whatever_the_slide_shape: tall, wide and 16:9 slides fit the column and keep their aspect; 16:9 keeps the full width.cargo xtask ci: all 6 steps pass.Overlap: #646 and #649 also edit
presenter_window, but they don't change these lines (only context). If one of them merges first, expect at most a trivial rebase.Parity checklist: this matches PowerPoint, which letterboxes the Next preview. No new rows.