Repository navigation
Format Shape: picture or texture fill options - #506
Merged
Merged
Conversation
shape.fill gains pictureProps for a picture fill: tile on/off, tile offset X/Y (pt), scale X/Y, alignment and mirror type, stretch offsets (left/top/right/bottom), and rotate with shape. `transparency` now also sets a picture fill's opacity. Values are clamped and unknown keywords or non-finite numbers ignored. The Fill page of the Format Shape pane gets a "Picture or texture fill" option with a picture source button and these controls. The model, renderer and PPTX reader/writer already carry the fields; a new engine test checks they survive a PPTX save and reopen. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 13, 2026
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shape.filltakespicturePropsto change a picture fill:tile: tile the picture, or stretch itoffsetX/offsetY(pt) andscaleX/scaleY: where the tiles sit and how big they arealignandmirror: tile alignment and mirror typestretch: offsets for a stretched picture, as[l, t, r, b]fractionsrotateWithShapetransparencynow also sets how opaque a picture fill is.a:tile,a:stretch/a:fillRect,alphaModFix,rotWithShape), so this PR adds no model or file-format changes. The new test checks that a PPTX save and reopen keeps them.docs/ui-parity.md: updated the Format Shape row.Test plan
shape_picture_fill_options_tile_offset_and_round_trip: stretch offsets, tile options, clamping, transparency, PPTX round tripcargo xtask ci(fmt, clippy, test, assets, layers, wasm) passes