Skip to content

UI: Paragraph dialog sets alignment, indents and spacing - #637

Merged
h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
NikitkaRa:cursor/paragraph-dialog-d175
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
NikitkaRa:cursor/paragraph-dialog-d175

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • Stacked on UI: Font dialog sets character formatting in one step #630.
  • format.paragraphDialog applies alignment, before/after text, first-line or hanging indent, spacing before and after, and line spacing (multiple or exactly) in one undo step. With no fields it opens the Paragraph dialog, seeded from the selection.
  • Home › Paragraph › Paragraph…, Line Spacing Options…, the shape menu, and the Format menu catalogue open it.
  • Text: Tabs dialog and the ruler's tab selector (stacked on #567) #569's Tabs dialog is not on main yet, so Tabs… opens a standalone Tabs dialog (format.tabs: stops and default interval, one undo). Whichever lands second should reconcile onto a single Tabs dialog. OK, Cancel, Esc or close returns to Paragraph with its unsaved fields kept.

Test plan

  • Engine tests: one undo for alignment, hanging indent and spacing; first line and exact spacing replace only those fields; opening with no fields does not edit; bad fields are rejected; tab stops collapse near-duplicates and undo together.
  • UI tests: Paragraph… sets alignment in one undo labeled "Paragraph…"; Tabs… applies a stop, returns to Paragraph with the edit uncommitted, and Cancel leaves alignment unchanged.
  • cargo fmt, clippy -D warnings, workspace tests (known macOS font/IME environment failures only), cargo xtask assets, layers, wasm
  • Sample deck: dialog opens seeded with Center alignment, zero indents, line spacing 0.9

NikitkaRa and others added 2 commits October 14, 2026 02:41
format.fontDialog applies family, size, bold, italic, underline, colour,
strikethrough, baseline, caps and spacing together, so one undo restores
them. With no fields it asks the UI to open the dialog, seeded from the
selection. Home › Font, the shape menu and Cmd+T open it.

Co-authored-by: Cursor <cursoragent@cursor.com>
format.paragraphDialog applies alignment, first-line and hanging
indents, spacing and line spacing in one undo step. With no fields it
opens the dialog from the Home › Paragraph launcher. Tabs… opens a
standalone Tabs dialog and returns to Paragraph.

Co-authored-by: Cursor <cursoragent@cursor.com>
@NikitkaRa NikitkaRa mentioned this pull request Oct 14, 2026
5 tasks done
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 12df77e into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…and #637

#569 and #637 each added a `format.tabs` command and a Tabs dialog. Keep one of each:
- format.tabs takes #567/#569's add/move/remove/clear/set plus #637's strict `set`
  (unknown alignment or non-object entries are errors, stops within 0.05 pt collapse,
  last wins) and opens the Tabs dialog when called with no fields, as #637 did.
  A defaultTab-only call no longer rewrites the stops.
- The Tabs dialog is #569's; it now seeds from the dialog's params when Paragraph (or
  format.tabs) opened it, and on OK hands the applied stops back to Paragraph.
- Tests adapted: an empty format.tabs opens the dialog; the Paragraph → Tabs test sets
  stops through #569's dialog fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…ver hit list

- #519's handle test iterated the old `ALL` preset list; main has `CATALOG` now.
- The hover hit-test match lists every Hit variant; add #519's Hit::Warp.
- Drop the duplicate "tabs" dialog title that #569 and #637 both added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
 #630 #637 #536 #559 #519 #506 #549 #556 #525)

# Conflicts:
#	crates/engine/src/cmd/review.rs
#	crates/engine/src/tests.rs
#	crates/ui-egui/src/dialogs.rs
#	crates/ui-egui/src/panes.rs
anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants