Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Jul 4, 2019

Because of conflicts with filters, we'd like to stop syncing some taxonomies. To take care of that, this PR introduces a term taxonomy blacklist, similar to the one we have for post types. It also

Changes proposed in this Pull Request:

  • Define taxonomy blacklist with possible get_* filter conflicts
  • Implement the taxonomy blacklist setting
  • Filter out blacklisted taxonomies when syncing terms
  • Exclude blacklisted taxonomies from term histogram
  • Add taxonomy blacklist tests

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Related with p5TWut-hM-p2 and p7rcWF-12N-p2

Testing instructions:

  • Checkout this branch.
  • Register a forbidden custom taxonomy (for example bloginfo_rss).
  • Create a term in that taxonomy, and verify it doesn't incrementally sync.
  • Trigger full sync, and verify it doesn't sync forbidden taxonomy terms.
  • Make sure tests pass.

Proposed changelog entry for your changes:

  • Sync: Implement term taxonomy blacklist

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Sync [Pri] Normal labels Jul 4, 2019
@tyxla tyxla added this to the 7.6 milestone Jul 4, 2019
@tyxla tyxla requested review from a team July 4, 2019 12:41
@tyxla tyxla self-assigned this Jul 4, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against c09c1bd

Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:magnifique:

@lezama
Copy link
Contributor

lezama commented Jul 4, 2019

Tested thoughtfully, everything seems to work as expected, thanks! 👍

@lezama lezama merged commit 3c73a19 into master Jul 4, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Jul 4, 2019
@lezama lezama deleted the add/sync-taxonomy-blacklist branch July 4, 2019 15:26
jeherve added a commit that referenced this pull request Jul 19, 2019
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Sync [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants