Skip to content

Conversation

@MichaelArestad
Copy link
Contributor

Looks like there was some old code that targeted Mozilla browsers (AKA Firefox) to fix some positioning specific on those browsers. It seems Firefox no longer needs that CSS and, in fact, the CSS actually makes it worse in Firefox so I removed it.

It's not clear why the code was added as it was ported into Jetpack three years ago and the original code is no longer easily available.

Changes proposed in this Pull Request:

  • Removed CSS targeting Firefox to position a form label

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Not a new feature. Nothing added.

Testing instructions:

  • In Firefox, go to Jetpack's Writing settings and make sure Enhanced CSS is enabled.
  • Go to Customizer.
  • Select the Custom CSS menu item.
  • Scroll down and look at the Media Width section to make sure the form label is aligned correctly.

Before

image

After

image

Proposed changelog entry for your changes:

  • No changelog needed, but if you want to add one: "Fixed label position in for Enhanced CSS option in the Customizer for Firefox users."

@MichaelArestad MichaelArestad added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Custom CSS [Status] Needs Review This PR is ready for review. [Pri] Normal labels Jul 15, 2019
@MichaelArestad MichaelArestad requested review from a team, crunnells and georgestephanis July 15, 2019 20:54
@MichaelArestad MichaelArestad self-assigned this Jul 15, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 6a644ef

Copy link
Contributor

@crunnells crunnells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 17, 2019
@jeherve jeherve added this to the 7.6 milestone Jul 17, 2019
@MichaelArestad MichaelArestad merged commit 9586b57 into master Jul 17, 2019
@MichaelArestad MichaelArestad deleted the fix/custom-css-label-positioning branch July 17, 2019 14:47
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 17, 2019
jeherve added a commit that referenced this pull request Jul 19, 2019
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Custom CSS [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants