Skip to content

Conversation

@poisa
Copy link
Contributor

@poisa poisa commented Jul 4, 2019

Changes proposed in this Pull Request:

The partner-provision.sh script is basically a client that calls the Jetpack Start API /provision endpoint. While D29544-code updates this endpoint to accept SSH credentials, this PR updates the shell script that calls that endpoint.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This updates an existing feature. Previously the provisioning script could not send SSH credentials. This PR allows it to do so thus making setting up VaultPress / Rewind easier for hosting partners.

For more info, see parMIr-cg-p2

Testing instructions:

  1. Create a new Jurassic Ninja site and take note of its SSH access credentials.
  2. Grab a hosting partner id and secret (Team Catalyst can provide you with one).
  3. Checkout this branch.
  4. Run the following command, replacing the strings in CAPS with your own
./bin/partner-provision.sh \
--partner_id=PARTNER_ID \
--partner_secret=PARTNER_SECRET \
--user=1 \
--plan=premium \
--url=JURASSIC_NINJA_URL \
--ssh-host=JURASSIC_NINJA_HOST \
--ssh-user=JURASSIC_NINJA_SSH_USER \
--ssh-pass=JURASSIC_NINJA_SSH_PASSWORD

The output of this command should be a JSON object. Make sure ssh_set is true and ssh_error is an empty string.

Note: For prettier JSON output, you can pipe the output of this command to jq.

Proposed changelog entry for your changes:

  • Add ability to send SSH credentials via bin/partner-provision.sh.

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 4, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 3847539

@poisa poisa marked this pull request as ready for review July 4, 2019 19:57
@poisa poisa requested a review from a team July 4, 2019 19:57
@poisa poisa added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 4, 2019
@poisa poisa requested review from a team, ebinnion and oikeme July 4, 2019 19:59
@jeherve jeherve added this to the 7.6 milestone Jul 5, 2019
Copy link
Contributor

@oikeme oikeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@poisa poisa removed the request for review from ebinnion July 8, 2019 18:22
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 17, 2019
@jeherve jeherve merged commit 8ed09c0 into master Jul 19, 2019
@jeherve jeherve deleted the update/ssh-credentials-to-partner-provision-script branch July 19, 2019 10:55
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 19, 2019
jeherve added a commit that referenced this pull request Jul 19, 2019
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants