-
Notifications
You must be signed in to change notification settings - Fork 845
AMP Compatibility: Remove social share CSS #12958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CSS for the share icons triggers a "illegal_css_at_rule" AMP validation error because of the use of '-moz-document'. Given AMP uses the `amp-social-share` component, this CSS isn't needed at all. This change tells Jetpack not to enqueue the CSS at all when an AMP page is being viewed.
|
Caution: This PR has changes that must be merged to WordPress.com |
This is an automated check which relies on |
|
This brings up something else: shouldn't the social sharing buttons in AMP get settled the same way as they do on the non-AMP page? The |
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works in my tests. 👍
* Add initial changelog / testing list changes for 7.6 * Update stable tag to 7.5.3 * changelog: add #12957 * Changelog: add #12932 * Changelog: add #12867 * Changelog: add #12823 * changelog: add #12969 * changelog: add #13012 * changelog: add #12974 * Changelog: add #13059 * Changelog: add #13079 * Changelog: add #12924 * changelog: add #12954 * Changelog: add #12959 * Changelog: add #12977 * Changelog: add #12830 * Changelog: add #12926 * Changelog: add #12958 * Changelog: add #12999 * Changelog: add #13077 * Changelog: add #13083 * Changelog: add #13087 * Changelog: add #13110 * Changelog: add #13116 * Changelog: add #13117 * Changelog: add #12821 * Changelog: add #13120 * changelog: add #13139 * Changelog: add #13143 * Changelog: add #13147 * Testing list: add section about sync
* Add initial changelog / testing list changes for 7.6 * Update stable tag to 7.5.3 * changelog: add #12957 * Changelog: add #12932 * Changelog: add #12867 * Changelog: add #12823 * changelog: add #12969 * changelog: add #13012 * changelog: add #12974 * Changelog: add #13059 * Changelog: add #13079 * Changelog: add #12924 * changelog: add #12954 * Changelog: add #12959 * Changelog: add #12977 * Changelog: add #12830 * Changelog: add #12926 * Changelog: add #12958 * Changelog: add #12999 * Changelog: add #13077 * Changelog: add #13083 * Changelog: add #13087 * Changelog: add #13110 * Changelog: add #13116 * Changelog: add #13117 * Changelog: add #12821 * Changelog: add #13120 * changelog: add #13139 * Changelog: add #13143 * Changelog: add #13147 * Testing list: add section about sync
Changes proposed in this Pull Request:
The CSS for the share icons triggers a "illegal_css_at_rule" AMP validation error because of the use of '-moz-document'. Given AMP uses the
amp-social-sharecomponent, this CSS isn't needed at all. This change tells Jetpack not to enqueue the CSS at all when an AMP page is being viewed.Is this a new feature or does it add/remove features to an existing part of Jetpack?
This builds upon existing AMP compatibility fixes.
Testing instructions:
illegal_css_at_rulevalidation errorProposed changelog entry for your changes: