Fixed variable name to the defined one. #13083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As declaraion is not defined, it generates a lot of notices and does not work correctly. I'm guessing the invociation should check for old_declaration.
Collaborator
This is an automated check which relies on |
jeherve
added
[Status] Needs Review
zinigor
approved these changes
Jul 25, 2019
Contributor
zinigor
left a comment
zinigor
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the warning, thank you!
zinigor
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
emilyatmobtown
pushed a commit
to emilyatmobtown/jetpack
that referenced
this pull request
Jul 26, 2019
As declaraion is not defined, it generates a lot of notices and does not work correctly. I'm guessing the invociation should check for old_declaration.
jeherve
added a commit
that referenced
this pull request
Jul 30, 2019
* Add initial changelog / testing list changes for 7.6 * Update stable tag to 7.5.3 * changelog: add #12957 * Changelog: add #12932 * Changelog: add #12867 * Changelog: add #12823 * changelog: add #12969 * changelog: add #13012 * changelog: add #12974 * Changelog: add #13059 * Changelog: add #13079 * Changelog: add #12924 * changelog: add #12954 * Changelog: add #12959 * Changelog: add #12977 * Changelog: add #12830 * Changelog: add #12926 * Changelog: add #12958 * Changelog: add #12999 * Changelog: add #13077 * Changelog: add #13083 * Changelog: add #13087 * Changelog: add #13110 * Changelog: add #13116 * Changelog: add #13117 * Changelog: add #12821 * Changelog: add #13120 * changelog: add #13139 * Changelog: add #13143 * Changelog: add #13147 * Testing list: add section about sync
jeherve
added a commit
that referenced
this pull request
Jul 30, 2019
* Add initial changelog / testing list changes for 7.6 * Update stable tag to 7.5.3 * changelog: add #12957 * Changelog: add #12932 * Changelog: add #12867 * Changelog: add #12823 * changelog: add #12969 * changelog: add #13012 * changelog: add #12974 * Changelog: add #13059 * Changelog: add #13079 * Changelog: add #12924 * changelog: add #12954 * Changelog: add #12959 * Changelog: add #12977 * Changelog: add #12830 * Changelog: add #12926 * Changelog: add #12958 * Changelog: add #12999 * Changelog: add #13077 * Changelog: add #13083 * Changelog: add #13087 * Changelog: add #13110 * Changelog: add #13116 * Changelog: add #13117 * Changelog: add #12821 * Changelog: add #13120 * changelog: add #13139 * Changelog: add #13143 * Changelog: add #13147 * Testing list: add section about sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Class_Moved::$declaraionis not defined, it generates a lot of notices and does not work correctly. I'm guessing the invociation should check for$old_declaration.Changes proposed in this Pull Request:
Running the Analyzer tool, I was getting a lot of
Notice: Undefined property: Automattic\Jetpack\Analyzer\Differences\Class_Moved::$declaration in .../jetpack/packages/analyzer/src/Differences/Class_Moved.php on line 32. My guess is that the check should happen againstold_declaration.Testing instructions:
When running the compat test for WC core, I noticed this problem. Details of setup along with scripts to run are available in this p2 post: pb22l9-1D-p2
Proposed changelog entry for your changes:
Class_Moved.