Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
# This is a combination of 4 commits.
# This is the 1st commit message:

Improve error message in case of missing property (#1012)

Co-authored-by: Artur Souza <[email protected]>
# This is the commit message #2:

Remove vestigial pubsub/nats code (#1024)

The pubsub/nats component was replaced by pubsub/natsstreaming as part
of dapr/dapr#2003, but the corresponding code
in dapr/components-contrib was not removed, so this change removes it.
# This is the commit message #3:

bugfix for sns topic deletion upon termination

# This is the commit message #4:

Revert "bugfix for sns topic deletion upon termination"

This reverts commit bcaa9bb.
  • Loading branch information
mthmulders authored and Amit Mor committed Jul 26, 2021
commit 5c9949b40a4f79afa70d54b5af19b1d941594a00
2 changes: 1 addition & 1 deletion bindings/smtp/smtp.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (s *Mailer) Invoke(req *bindings.InvokeRequest) (*bindings.InvokeResponse,
// Merge config metadata with request metadata
metadata := s.metadata.mergeWithRequestMetadata(req)
if metadata.EmailFrom == "" {
return nil, fmt.Errorf("smtp binding error: fromEmail property not supplied in configuration- or request-metadata")
return nil, fmt.Errorf("smtp binding error: emailFrom property not supplied in configuration- or request-metadata")
}
if metadata.EmailTo == "" {
return nil, fmt.Errorf("smtp binding error: emailTo property not supplied in configuration- or request-metadata")
Expand Down
11 changes: 0 additions & 11 deletions pubsub/nats/metadata.go

This file was deleted.

99 changes: 0 additions & 99 deletions pubsub/nats/nats.go

This file was deleted.

69 changes: 0 additions & 69 deletions pubsub/nats/nats_test.go

This file was deleted.