refactor(api): move deployment logic to separate package #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 58.43% 59.02% +0.59%
==========================================
Files 270 269 -1
Lines 15636 15479 -157
==========================================
Hits 9137 9137
+ Misses 6075 5918 -157
Partials 424 424 |
plyr4
previously approved these changes
May 17, 2023
cognifloyd
reviewed
May 17, 2023
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Minor nit - some copy pasta that already existed before this PR.
api/deployment/get.go
Outdated
Comment on lines
40
to
41
| // name: deployment | ||
| // description: Name of the org |
Member
There was a problem hiding this comment.
Suggested change
| // name: deployment | |
| // description: Name of the org | |
| // name: deployment | |
| // description: Number of the deployment |
cognifloyd
approved these changes
May 17, 2023
plyr4
approved these changes
May 17, 2023
This was referenced May 17, 2023
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #615 #754 #809 #828 and #829
This change continues the refactor efforts initially introduced in the above PR.
This adds a new
deploymentpackage to thegithub.amrom.workers.dev/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
I also updated a few of the previous packages in this refactor effort to have a
doc.gofile.