refactor(api): move service logic to separate package #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 61.29% 62.18% +0.89%
==========================================
Files 282 281 -1
Lines 15331 15111 -220
==========================================
Hits 9397 9397
+ Misses 5491 5271 -220
Partials 443 443
|
cognifloyd
reviewed
May 18, 2023
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Just a minor nit about import sorting. LGTM otherwise.
cognifloyd
approved these changes
May 18, 2023
plyr4
approved these changes
May 19, 2023
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #615 #754 #809 #828 #829 #847 and #848.
This change continues the refactor efforts initially introduced in the above PRs.
This adds a new
servicepackage to thegithub.amrom.workers.dev/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
Moved
planServicesto theapi/build.gofile with the intent of creating aapi/service/plan.gofile later in this refactor, which will include an exportablePlanServicesfor use inRestartBuildand scheduled builds. Open to other ideas with that too.Also changed
GetServicestoListServicesto stay consistent.