Skip to content

Conversation

@ecrupper
Copy link
Contributor

Based off of #615 #754 #809 #828 #829 #847 #848 #849 #851 #853 and #855

This change continues the refactor efforts initially introduced in the above PRs.

This adds a new secret package to the github.com/go-vela/server/api package.

This contains all the same handlers that existed previously but with each of them within their own file.

Moved the unique helper function to the github.com/go-vela/server/util package, as it seems well-placed there, but I'm willing to move it back into the secret package if requested.

Also changed GetSecret to ListSecrets to stay consistent.

@ecrupper ecrupper requested a review from a team as a code owner May 22, 2023 15:27
@ecrupper ecrupper self-assigned this May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #856 (d0c14df) into main (4ffd2f1) will increase coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   64.84%   66.78%   +1.94%     
==========================================
  Files         284      283       -1     
  Lines       14543    14120     -423     
==========================================
  Hits         9430     9430              
+ Misses       4667     4244     -423     
  Partials      446      446              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants