refactor(api): move build logic to separate package #864
Conversation
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 66.13% 71.72% +5.59%
==========================================
Files 297 304 +7
Lines 13876 12794 -1082
==========================================
Hits 9177 9177
+ Misses 4252 3170 -1082
Partials 447 447
|
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| // swagger:operation GET /api/v1/repos/{org}/{repo}/builds/{build}/token builds GetBuildToken |
There was a problem hiding this comment.
I wonder if this endpoint should be in the api/auth package instead of api/build since it is auth-specific. Then all of the auth stuff is in the same package even if the API spreads it across a variety of endpoints. What do you think?
There was a problem hiding this comment.
Yeah I was thinking similarly, but landed on sticking with the build package since the URL path is very much of the build flavor.
|
|
||
| // getPRNumberFromBuild is a helper function to | ||
| // extract the pull request number from a Build. | ||
| func getPRNumberFromBuild(b *library.Build) (int, error) { |
There was a problem hiding this comment.
this is used for both CreateBuild and UpdateBuild but is in create.go - should it go in a file on its own? 🤔
It's probably fine here, but I'm asking anyway. 🤷
There was a problem hiding this comment.
Going to leave it there for now, but I almost wonder if this belongs in types rather than as a helper function
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Some misc questions and a couple typos.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Based off of #615 #754 #809 #828 #829 #847 #848 #849 #851 #853 #855 and #856
This change continues the refactor efforts initially introduced in the above PRs.
This adds a new
buildpackage to thegithub.amrom.workers.dev/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
It also adds a new
webhookpackage in order to exportPublishToQueueas a function withinbuildpackage.Now that build has been moved to its own package, I was also able to put
PlanStepsandPlanServicesin their respective packages.