This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update XCMP draft to master #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix * Update consensus/src/lib.rs Co-Authored-By: Bastian Köcher <[email protected]>
* fix * Update consensus/src/lib.rs Co-Authored-By: Bastian Köcher <[email protected]>
retry on gitlab system failures
Add test parachain
implementation of BlockAnnounceValidator
Clarify instructions for registering a parachain.
CI optimizations
* Rewrite collator future * Add future to tests
Fixes #34 Added .editorconfig
* Update substrate: async API fix * Fix to update polkadot and substrate * Update substrate & polkadot to use cumulus-branch * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]>
* Update Cargo.lock * Fix for substrate update * Update Cargo.lock * Fix for substrate update * Fix for substrate update * Fix for substrate update * Fix for substrate update * Update Cargo.lock * Fix for substrate update * Fix for substrate update * Fix for substrate update * Fix for substrate update * Fix for substrate update * WIP * Temporary fix until polkadot is fixed * WIP * WIP
* Initial commit Forked at: 0efd15c Parent branch: master * Update substrate: more CLI improvement * Update substrate and polkadot to cecton-cumulus-branch * WIP Forked at: 0efd15c Parent branch: master * Update Cargo.lock * WIP Forked at: 0efd15c Parent branch: master * WIP Forked at: 0efd15c Parent branch: master * Update Cargo.lock * WIP Forked at: 0efd15c Parent branch: master * WIP Forked at: 0efd15c Parent branch: master * Test running node and interrupts * WIP Forked at: 0efd15c Parent branch: master * Update Cargo.lock * Update test/parachain/tests/running_the_node_and_interrupt.rs Co-Authored-By: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Deactivate mdns for polkadot node as it prevents the process to exit properly Fixes #57
* Update README to fix the startup * Add missing `=` * Apply suggestions from code review
* add polkadot build script * Add scripting to bring up a simple alice-bob example net Demonstrated to produce blocks, but as of right now there's still trouble getting it to respond to external queries on its ports. * enable external rpc access to the nodes Also shrink the build context by excluding some extraneous data. * Ensure external RPC access works Also set default branch appropriately, and have the stop command clean itself up more thoroughly. * Add multi-stage dockerfile for building the cumulus-test-parachain-collator - Exclude the docker/ directory from build context because we're never going to build recursively, and this prevents spurious cache misses - build the parachain collator in three stages. The build stage is discarded; the collator stage has a wrapper script to simplify generating the right bootnodes flags, and the default stage has just the binary in a small runtime. - build_collator.sh collects appropriate build flags for the dockerfile - inject_bootnodes.sh discovers the testnet node IDs and inserts them into the arguments list for cumulus-test-parachain-collator * Add services which generate genesis state, run the collator - Ignore the scripts directory to reduce spurious cache misses. - Move inject_bootnodes.sh from the scripts directory into the root: It can't stay in the scripts directory, because that's ignored; I didn't want to invent _another_ top-level subdirectory for it. That decision could certainly be appealed, though. - Move docker-compose.yml, add dc.sh, modify *_collator.sh: by taking docker-compose.yml out of the root directory, we can further reduce cache misses. However, docker-compose normally has a strong expectation that docker-compose.yml exist in the project root; it takes a moderately complicated invocation to override that expectation. That override is encoded in dc.sh; the updates to the other scripts are just to use the override. The expectation as of now is that scripts/run_collator.sh runs both chain nodes and the collator, generates the genesis state into a volume with a transient container, and runs the collator as specified in the repo README. Upcoming work: Steps 5 and 6 from the readme. * Launch the collator node The biggest change here is adding the testing_net network to the collator node's networks list. This lets it successfully connect to the alice and bob nodes, which in turn lets it get their node IDs, which was the blocker for a long time. Remove httpie in favor of curl: makes for a smaller docker image, and has fewer weird failure modes within docker. Unfortunately this doesn't yet actually connect to the relay chain nodes; that's the next area to figure out. * enable external websocket access to indexer nodes * Reorganize for improved caching, again - Manually enumerate the set of source directories to copy when building. This bloats the cache a bit, but means that rebuilds on script changes don't bust that cache, which saves a _lot_ of time. - Un-.dockerignore the scripts directory; it's small and will no longer trigger cache misses. - Move inject_bootnodes.sh back into scripts directory for better organization. - inject_bootnodes.sh: use rpc port for rpc call and p2p port for generating the bootnode string. I'm not 100% sure this is correct, but upwards of 80% at least. - docker-compose.yml: reorganize the launch commands such that alice and bob still present the same external port mapping to the world, but within the docker-compose network, they both use the same (standard) p2p, rpc, and websocket ports. This makes life easier for inject_bootnodes.sh The collator node still doesn't actually connect, but I think this commit still represents real progress in that direction. * Get the collator talking to the indexer nodes In the end, it was four characters: -- and two = signs in the launch arguments. They turn out to be critical characters for correct operation, though! Next up: automating step 5. * Add runtime stage to collect runtime wasm blob into volume We can't just copy the blob in the builder stage because the volumes aren't available at that point. Rewrite build_collator.sh into build_docker.sh and update for generality. * WIP: add registrar service and partial work to actually register the collator This is likely to be discarded; the Python library in use is 3rd party and not well documented, while the official polkadot-js repo has a CLI tool: https://github.com/polkadot-js/tools/tree/master/packages/api-cli * Add a parachain registrar which should properly register the parachain Doesn't work at the moment because it depends on two api-cli features which I added today, which have not yet made it out into a published release. Next up: figure out how to add the `api-cli` at its `master` branch, then run tests to ensure the collator is producing blocks. Then, automate the block production tests. * BROKEN attempt to demo registrar communication with the blockchain This is a really weird bug. After running `scripts/run_collector.sh`, which brings everything up, it's perfectly possible to get into a state very much like what the registrar is in, and communicate with the blockchain without issue: ```sh $ docker run --rm --net cumulus_testing_net para-reg:latest polkadot-js-api --ws ws://172.28.1.1:9944 query.sudo.key Thu 20 Feb 2020 12:19:20 PM CET { "key": "5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY" } ``` However, the registrar itself, doing the same thing from within `register_para.sh`, is failing to find the right place in the network: ``` /runtime/cumulus_test_parachain_runtime.compact.wasm found after 0 seconds /genesis/genesis-state found after 0 seconds 2020-02-20 10:43:22 API-WS: disconnected from ws://172.28.1.1:9944 code: '1006' reason: 'connection failed' _Event { type: 'error', isTrusted: false, _yaeti: true, target: W3CWebSocket { _listeners: {}, addEventListener: [Function: _addEventListener], removeEventListener: [Function: _removeEventListener], dispatchEvent: [Function: _dispatchEvent], _url: 'ws://172.28.1.1:9944', _readyState: 3, _protocol: undefined, _extensions: '', _bufferedAmount: 0, _binaryType: 'arraybuffer', _connection: undefined, _client: WebSocketClient { _events: [Object: null prototype] {}, _eventsCount: 0, _maxListeners: undefined, config: [Object], _req: null, protocols: [], origin: undefined, url: [Url], secure: false, base64nonce: 'aJ6J3pYDz8l5owVWHGbzHg==', [Symbol(kCapture)]: false }, onclose: [Function (anonymous)], onerror: [Function (anonymous)], onmessage: [Function (anonymous)], onopen: [Function (anonymous)] }, cancelable: true, stopImmediatePropagation: [Function (anonymous)] } ``` They should be connected to the same network, running the same image, doing the same call. The only difference is the file existence checks, which really shouldn't be affecting the network state at all. Pushing this commit to ask for outside opinions on it, because this is very weird and I clearly don't understand some part of what's happening. * Fix broken parachain registrar The problem was that the registrar container was coming up too fast, so the Alice node wasn't yet ready to receive connections. Using a well-known wait script fixes the issue. Next up: verify that the collator is in fact building blocks. * fixes which cause the collator to correctly produce new parachain blocks It didn't take much! The biggest issue was that the genesis state was previously being double-encoded. * add documentation for running the parachain automatically * Add health check to collator * minor scripting improvements * Apply suggestions from code review Co-Authored-By: Bastian Köcher <[email protected]> * Docker: copy the whole workspace in one go Pro: future-proofing against the time we add or remove a directory Con: changing any file in the workspace busts Rust's build cache, which takes a long time. Co-authored-by: Bastian Köcher <[email protected]>
* Update Polkadot/Substrate * Update branch
This action will publish all pre-released, edited and published releases to a dedicated release notes Matrix room using https://github.com/marketplace/actions/matrix-message @s3krit already added the necessary secrets to the repository settings.
* Adds some highlevel docs for Cumulus * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> Co-Authored-By: Joshy Orndorff <[email protected]> Co-Authored-By: Nikolay Volf <[email protected]> * Update docs/overview.md Co-Authored-By: Shawn Tabrizi <[email protected]> * Update docs/overview.md Co-Authored-By: Robert Habermeier <[email protected]> * Add sentence Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: Robert Habermeier <[email protected]>
* Start fixing compilation errors * Switch to git version of `WasmBuilder` * Fix compilation * More updates * Adapt to latest Substrate/Polkadot changes
JoshOrndorff
changed the title
Member
|
Closing it in favor of: #80 |
Maharacha
pushed a commit
to Maharacha/cumulus
that referenced
this pull request
May 10, 2023
* run launch-runtime benchmarks on devsgx02 * integrate benchmarks and fix typo paritytech#76 * upgrade hardcoded genesis spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically merges master into #16. Two questions about this work.
@gavofyork The nomenclature that was already in ICMP runtime module #16 uses "icmp" to refer to messages from parachains as well as from the relay chain. That's different than the definition of xcmp we discussed recently. Would you like me to update the code to match our recent discussions, or do a more trivial s/icmp/xcmp/g?
This compiles when I run
cargo check -p cumulus-runtimebut not when I just runcargo checkin the root. How can I solve that?