Skip to content

Conversation

Copy link

Copilot AI commented Oct 30, 2025

Fixed linting issues in the Cloudflare handler that were blocking CI. The import order violated biome's organization rules.

Changes

  • Reorganized imports in handler.ts to comply with biome linter (virtual module imports before type imports)
  • Fixed code formatting (spacing in if statement, trailing comma)

These changes ensure the PR passes pnpm run lint:ci.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: 10e2531

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Add full sessions support with environment API fix: organize imports and formatting in cloudflare handler Oct 30, 2025
Copilot AI requested a review from matthewp October 30, 2025 18:59
@matthewp matthewp marked this pull request as ready for review October 30, 2025 19:09
@matthewp matthewp merged commit 9af11de into feat/sessions-environment-api Oct 30, 2025
@matthewp matthewp deleted the copilot/sub-pr-14696 branch October 30, 2025 19:10
matthewp added a commit that referenced this pull request Oct 31, 2025
* feat: full sessions support w/ environment api

- create virtual module for cloudflare config (sessionKVBindingName)
- handler dynamically accesses binding from env via virtual module
- remove hardcoded SESSION binding name, now configurable
- remove unused __env__ global
- add test fixture with sessions form
- sessions now fully integrated with astro environment api

* fix: organize imports and formatting in cloudflare handler (#14697)

* Initial plan

* fix: organize imports and formatting in handler.ts

Co-authored-by: matthewp <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: matthewp <[email protected]>

* fix: make CloudflareConfig interface internal

* fix: use AstroError for session driver resolution failures

* fix: organize imports in session vite plugin

* fix: move virtual.d.ts to package root

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: matthewp <[email protected]>
ematipico added a commit that referenced this pull request Dec 4, 2025
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Alexander Niebuhr <[email protected]>
Co-authored-by: ascorbic <[email protected]>
Co-authored-by: matthewp <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: florian-lefebvre <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by:  Matthew Phillips <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Hayato Hasegawa <[email protected]>
fix: creation of routes list in build (#14325)
Fix unit tests for environment API (#14394)
fixture (#14599)
fix: organize imports and formatting in cloudflare handler (#14697)
fix: resolve environment-api build issues for client & CSS (#14770)
Fixes CSS when both static/client styles exist (#14790)
fix: flag `serverLike` incorrectly computed (#14792)
fix: redirects and i18n routing (#14797)
fix: logger level and static paths params (#14799)
Fix image tests crashing (#14803)
fix(environment): Error overlay not working (#14816)
fix: hashing of chunks (#14811)
Fix before-hydration script emission for environment-api (#14818)
fix: node leak into content collections (#14820)
fix: avoid `node:path` (#14827)
Fix API route tests (#14825)
Fix unit tests (#14832)
fix: server islands build (#14830)
Fix astro-component-bundling tests (#14840)
Fix astro-component-bundling tests (#14837)
Fix config alias by using resolve.alias config (#14828)
fix: container and routing tests (#14852)
fix: respect user vite config on sourcemaps (#14847)
fix: remove useless tests (#14854)
Fixes assetQueryParams and public folder tests (#14853)
fix: renderError fallback (#14855)
Fix server-islands data being used across tests (#14857)
fix: incorrect configuration in tests (#14858)
Fixes for tests in environment branch (#14865)
Fixes for e2e tests in environment branch (#14870)
fix(test): svelte async rendering (#14886)
fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892)
Fixes for node integrations tests (#14900)
Fix @astrojs/db tests (#14899)
fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921)
Fix remaining cloudflare tests (#14912)
fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939)
Fix astro:env tests in Cloudflare (#14925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants