Skip to content

fix(cloudflare/vercel/netlify): some tests pass and excluded others #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ematipico merged 3 commits into from
Nov 25, 2025
Merged

fix(cloudflare/vercel/netlify): some tests pass and excluded others #14892

ematipico merged 3 commits into from
Nov 25, 2025

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Nov 25, 2025

Changes

This PR does the following:

  • fixes Vercel tests, however, I'm not sure if updating those tests yields the correct result. Please double check
  • fixes Netlify tests

As for the cloudflare tests, here's the changes:

  • fixes an issue where the manifest wasn't correctly provided during sync. During sync, we were providing the placeholder manifest, which is then replaced only at the end of the build. I added a !sync check.
  • The Cloudflare Vite plugin now requires a configuration file. I updated the adapter to provide a default one. This might be a temporary solution, as they told us that the cloudflare vite plugin will be able to accept an inline configuration
  • Some tests are temporarily skipped because they require a build step. They will work again once the preview server is implemented. The Cloudflare Vite plugin supports preview now.
  • For some reason, .dev.vars aren't read when testing a file, skipped for now and added a todo

Then other changes:

  • Vite was throwing a warning for incorrect imports. With packages/astro/src/entrypoints/prerender.ts changes, this is now fixed

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e3b6ff4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 25, 2025
@ematipico ematipico changed the title fix(cloudflare/vercel/netlify): some tests pass and excluded fix(cloudflare/vercel/netlify): some tests pass and excluded others Nov 25, 2025
@matthewp
Copy link
Contributor

matthewp commented Nov 25, 2025

I think the E2E failing is likely flakiness, but I'd rerun it to be sure.

matthewp
matthewp reviewed Nov 25, 2025
View reviewed changes
packages/integrations/cloudflare/src/index.ts
function wranglerTemplate(): string {
const wrangler = {
// TODO: better way to handle name, maybe package.json#name ?
name: 'test-application',
Copy link
Contributor

@matthewp matthewp Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is name required? If not maybe we can just omit it.

Copy link
Member Author

@ematipico ematipico Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required yes

@matthewp
Copy link
Contributor

matthewp commented Nov 25, 2025

@ematipico can you add an issue to the board about the preview server thing. I can likely work on that once we have tests finished.

matthewp
matthewp reviewed Nov 25, 2025
View reviewed changes
@ematipico ematipico requested a review from matthewp November 25, 2025 13:55
@ematipico ematipico merged commit c0553c1 into feat/environment-api Nov 25, 2025
18 of 22 checks passed
@ematipico ematipico deleted the env-api/cloudflare-tests-fixes branch November 25, 2025 16:19
ematipico added a commit that referenced this pull request Dec 4, 2025
@ematipico @penalosa
@alexanderniebuhr @ascorbic @matthewp @florian-lefebvre @sarah11918 @Princesseuh @hasegawa-101
Environment API (#14306)
141c4a2 
Co-authored-by: Emanuele Stoppa <[email protected]>
Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Alexander Niebuhr <[email protected]>
Co-authored-by: ascorbic <[email protected]>
Co-authored-by: matthewp <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
Co-authored-by: florian-lefebvre <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by:  Matthew Phillips <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Hayato Hasegawa <[email protected]>
fix: creation of routes list in build (#14325)
Fix unit tests for environment API (#14394)
fixture (#14599)
fix: organize imports and formatting in cloudflare handler (#14697)
fix: resolve environment-api build issues for client & CSS (#14770)
Fixes CSS when both static/client styles exist (#14790)
fix: flag `serverLike` incorrectly computed (#14792)
fix: redirects and i18n routing (#14797)
fix: logger level and static paths params (#14799)
Fix image tests crashing (#14803)
fix(environment): Error overlay not working (#14816)
fix: hashing of chunks (#14811)
Fix before-hydration script emission for environment-api (#14818)
fix: node leak into content collections (#14820)
fix: avoid `node:path` (#14827)
Fix API route tests (#14825)
Fix unit tests (#14832)
fix: server islands build (#14830)
Fix astro-component-bundling tests (#14840)
Fix astro-component-bundling tests (#14837)
Fix config alias by using resolve.alias config (#14828)
fix: container and routing tests (#14852)
fix: respect user vite config on sourcemaps (#14847)
fix: remove useless tests (#14854)
Fixes assetQueryParams and public folder tests (#14853)
fix: renderError fallback (#14855)
Fix server-islands data being used across tests (#14857)
fix: incorrect configuration in tests (#14858)
Fixes for tests in environment branch (#14865)
Fixes for e2e tests in environment branch (#14870)
fix(test): svelte async rendering (#14886)
fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892)
Fixes for node integrations tests (#14900)
Fix @astrojs/db tests (#14899)
fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921)
Fix remaining cloudflare tests (#14912)
fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939)
Fix astro:env tests in Cloudflare (#14925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ematipico @matthewp