Fix remaining cloudflare tests #14912
Conversation
|
github-actions
bot
added
the
pkg: integration
|
|
||
| export interface Runtime<T extends object = object> { | ||
| export interface Runtime { | ||
| runtime: { |
There was a problem hiding this comment.
I think we may want to change this object shape? locals.runtime.ctx may not make a lot of sense anymore. What about, idk, locals.cfContext?
There was a problem hiding this comment.
I thought about something like that, but given that Astro.locals.runtime is already a existing object for the cloudflare integration and the variable is always documented as ctx I thought just making this as backwards compat as possible, for now, would be best.
There was a problem hiding this comment.
Given we remove all other properties already, not sure I agree. I'd say we should either keep everything and deprecate things if needed for backward compatibility, or start clean and design the API as we'd like it ideally
There was a problem hiding this comment.
ok i switched to cfContext
|
|
||
| injectTypes({ | ||
| filename: 'cloudflare.d.ts', | ||
| content: '/// <reference types="@astrojs/cloudflare/types.d.ts" />', |
There was a problem hiding this comment.
You may need to update the package.json exports to make it work
Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Samuel Macleod <[email protected]> Co-authored-by: Alexander Niebuhr <[email protected]> Co-authored-by: ascorbic <[email protected]> Co-authored-by: matthewp <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: florian-lefebvre <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Hayato Hasegawa <[email protected]> fix: creation of routes list in build (#14325) Fix unit tests for environment API (#14394) fixture (#14599) fix: organize imports and formatting in cloudflare handler (#14697) fix: resolve environment-api build issues for client & CSS (#14770) Fixes CSS when both static/client styles exist (#14790) fix: flag `serverLike` incorrectly computed (#14792) fix: redirects and i18n routing (#14797) fix: logger level and static paths params (#14799) Fix image tests crashing (#14803) fix(environment): Error overlay not working (#14816) fix: hashing of chunks (#14811) Fix before-hydration script emission for environment-api (#14818) fix: node leak into content collections (#14820) fix: avoid `node:path` (#14827) Fix API route tests (#14825) Fix unit tests (#14832) fix: server islands build (#14830) Fix astro-component-bundling tests (#14840) Fix astro-component-bundling tests (#14837) Fix config alias by using resolve.alias config (#14828) fix: container and routing tests (#14852) fix: respect user vite config on sourcemaps (#14847) fix: remove useless tests (#14854) Fixes assetQueryParams and public folder tests (#14853) fix: renderError fallback (#14855) Fix server-islands data being used across tests (#14857) fix: incorrect configuration in tests (#14858) Fixes for tests in environment branch (#14865) Fixes for e2e tests in environment branch (#14870) fix(test): svelte async rendering (#14886) fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892) Fixes for node integrations tests (#14900) Fix @astrojs/db tests (#14899) fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921) Fix remaining cloudflare tests (#14912) fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939) Fix astro:env tests in Cloudflare (#14925)
Changes
request.cfandimport { env } from 'cloudflare:workers'instead.Testing
Docs
N/A