Fix image tests crashing #14803

matthewp · 2025-11-18T20:18:09Z

Changes

This prevents the image tests from crashing. The problem is that there is a circular reference within the Image component. Because the dev:css plugin was invalidating the image.css during loading it resulted in the page never finishing, until it ultimately ran out of memory.

The fix here was to move away from a single global dev:css module and instead create a virtual:astro:dev:css:${route} module for each of these.

This fixes the problem in that we don't need to invalidate any more, each page CSS is represented on its own.

Testing

packages/astro/test/core-image-layout.test.js no longer crashes
most tests pass in packages/astro/test/core-image-layout.test.js (1 is failing but unrelated to this change)

Docs

N/A, bug fix

This prevents the image tests from crashing. The problem is that there is a circular reference within the Image component. Because the dev:css plugin was invalidating the image.css during loading it resulted in the page never finishing, until it ultimately ran out of memory. The fix here was to move away from a single global dev:css module and instead create a virtual:astro:dev:css:${route} module for each of these. This fixes the problem in that we don't need to invalidate any more, each page CSS is represented on its own.

changeset-bot · 2025-11-18T20:18:15Z

⚠️ No Changeset found

Latest commit: 56cef70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matthewp · 2025-11-18T20:51:59Z

 tests 1974
ℹ suites 762
ℹ pass 1813
ℹ fail 121
ℹ cancelled 31
ℹ skipped 9
ℹ todo 0

ematipico

Mostly nits, I do have some concerns about using the loader, which should nuke at some point

ematipico · 2025-11-19T08:34:56Z

packages/astro/src/core/build/static-build.ts

 							entryFileNames: `${settings.config.build.assets}/[name].[hash].js`,
 							chunkFileNames: `${settings.config.build.assets}/[name].[hash].js`,
 							assetFileNames: `${settings.config.build.assets}/[name].[hash][extname]`,
+							...viteConfig.environments?.client?.build?.rollupOptions?.output,


What are we fixing/adding here?

This is the script tests you asked about below, this allows people to customize the client-side output names.

ematipico · 2025-11-19T08:35:52Z

packages/astro/src/vite-plugin-app/pipeline.ts

 		}

-		const { css } = await import('virtual:astro:dev-css');
+		const { css } = await loader.import(getDevCSSModuleName(routeData.component));


If possible, we shouldn't rely on the loader anymore. We actually want to move away from it eventually, because it goes in conflicts with the new architecture.

In fact, it's possible we won't need this pipeline anymore once we're able to provide all the features using DevApp

Not sure I understand, you can't import Vite code using the real dynamic import. It fails without this change.

That's the concerning part. Why does it work with Cloudflare, and not without it?

Because that code runs inside of the Vite runtime and this does not. So when you use regular dynamic import you are using Node.js module loader which of course can't resolve this. So we use loader to make it load inside the Vite environment.

ematipico · 2025-11-19T08:39:02Z

packages/astro/src/vite-plugin-css/util.ts

+import { getVirtualModulePageName } from '../vite-plugin-pages/util.js';
+
+const MODULE_DEV_CSS_PREFIX = 'virtual:astro:dev-css:';
+
+/**
+ * Get the virtual module name for a dev CSS import.
+ * Usage: `await loader.import(getDevCSSModuleName(routeData.component))`
+ */
+export function getDevCSSModuleName(componentPath: string): string {
+	return getVirtualModulePageName(MODULE_DEV_CSS_PREFIX, componentPath);
+}


I think this utility should be moved next to its opposite function. Plus, we're repeating the module prefix, while we should instead use one constant to reduce errors

ematipico · 2025-11-19T08:40:15Z

packages/astro/test/ssr-script.test.js

+					environments: {
+						client: {
+							build: {
+								rollupOptions: {
+									output: {
+									  entryFileNames: 'assets/entry.[hash].mjs',
+									  chunkFileNames: 'assets/chunks/chunk.[hash].mjs',
+									  assetFileNames: 'assets/asset.[hash][extname]',
+									}
+								}
+							}
+						}
+					}


The PR doesn't mention anything about this change. Is it related to the CSS? If so, how does it affect it? If not, what does this change do?

Co-authored-by: Emanuele Stoppa <[email protected]> Co-authored-by: Samuel Macleod <[email protected]> Co-authored-by: Alexander Niebuhr <[email protected]> Co-authored-by: ascorbic <[email protected]> Co-authored-by: matthewp <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> Co-authored-by: Matt Kane <[email protected]> Co-authored-by: florian-lefebvre <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Matthew Phillips <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Hayato Hasegawa <[email protected]> fix: creation of routes list in build (#14325) Fix unit tests for environment API (#14394) fixture (#14599) fix: organize imports and formatting in cloudflare handler (#14697) fix: resolve environment-api build issues for client & CSS (#14770) Fixes CSS when both static/client styles exist (#14790) fix: flag `serverLike` incorrectly computed (#14792) fix: redirects and i18n routing (#14797) fix: logger level and static paths params (#14799) Fix image tests crashing (#14803) fix(environment): Error overlay not working (#14816) fix: hashing of chunks (#14811) Fix before-hydration script emission for environment-api (#14818) fix: node leak into content collections (#14820) fix: avoid `node:path` (#14827) Fix API route tests (#14825) Fix unit tests (#14832) fix: server islands build (#14830) Fix astro-component-bundling tests (#14840) Fix astro-component-bundling tests (#14837) Fix config alias by using resolve.alias config (#14828) fix: container and routing tests (#14852) fix: respect user vite config on sourcemaps (#14847) fix: remove useless tests (#14854) Fixes assetQueryParams and public folder tests (#14853) fix: renderError fallback (#14855) Fix server-islands data being used across tests (#14857) fix: incorrect configuration in tests (#14858) Fixes for tests in environment branch (#14865) Fixes for e2e tests in environment branch (#14870) fix(test): svelte async rendering (#14886) fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892) Fixes for node integrations tests (#14900) Fix @astrojs/db tests (#14899) fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921) Fix remaining cloudflare tests (#14912) fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939) Fix astro:env tests in Cloudflare (#14925)

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 18, 2025

build and lint stuff

4f9a703

matthewp marked this pull request as ready for review November 18, 2025 20:52

matthewp added 2 commits November 18, 2025 16:07

small refactor

fbab0da

add more fixes

56cef70

ematipico approved these changes Nov 19, 2025

View reviewed changes

matthewp merged commit 8a43add into feat/environment-api Nov 19, 2025
9 of 21 checks passed

matthewp deleted the fix-crash-of-tests branch November 19, 2025 13:05

Uh oh!

Fix image tests crashing #14803

Fix image tests crashing #14803

Uh oh!

Conversation

matthewp commented Nov 18, 2025

Changes

Testing

Docs

Uh oh!

changeset-bot bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

matthewp commented Nov 18, 2025

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Nov 18, 2025 •

edited

Loading