Protect: Add Home page #40317

dkmyta · 2024-11-22T21:16:44Z

Description

Add Home tab, page and stat cards.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-scan-team/issues/1565

Does this pull request change what data or activity we track or use?

Testing instructions:

Checkout this branch load Protect in JT
Ensure you are redirected to the Home tab after passing setup
Review the various states of the HomeStatCards error, scanning, idle, disabled
Ensure no regressions are introduced

Screenshots

github-actions · 2024-11-22T21:18:42Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-11-29T19:21:41Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect/home branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/protect/home

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/home

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

dkmyta · 2024-12-05T22:45:07Z

projects/plugins/protect/src/class-jetpack-protect.php


 		return array(
-			'blockedRequests'           => Plan::has_required_plan() ? Waf_Stats::get_blocked_requests() : false,
+			'blockedRequests'           => Waf_Stats::get_blocked_requests(),


Makes stats available regardless of plan

nateweller · 2024-12-05T23:10:02Z

Header alignment issue when scan in progress on a free plan

nateweller · 2024-12-05T23:12:56Z

Scan upgrade prompt should redirect to /scan after checkout

dkmyta · 2024-12-05T23:13:25Z

Header alignment issue when scan in progress on a free plan

Darnit, I had this fixed previously - I think a few things unforuntately got overwritten in the most recent rebase. Hopefully not much else 😬

nateweller · 2024-12-05T23:19:46Z

Mismatching line counts across stat cards, we could either apply whitespace: nowrap here as has been done in the Firewall tab header, or update the labels to all wrap two lines?

dkmyta · 2024-12-05T23:22:57Z

Mismatching line counts across stat cards, we could either apply whitespace: nowrap here as has been done in the Firewall tab header, or update the labels to all wrap two lines?

This was a discussion with @ilonagl - the issue with nowrap was that when we are viewing free results the scan card uses the term Vulnerabilities which is too long to fit on a single line. The solution was wrapping the text, but I agree with ensuring there are two lines always 👍🏻

dkmyta · 2024-12-05T23:26:32Z

Scan upgrade prompt should redirect to /scan after checkout

I suppose we'll need to upgrade all applicable uses of upgradePlan to supply a redirect now, I guess setting that as the default is best. I wonder if there is also an opportunity here to add a upgrade CTA to the new Home page 🤔

nateweller · 2024-12-06T18:25:47Z

The stat cards start wrapping into the next line on < 1400px screen widths, and overflowing horizontally when they are lined up.

dkmyta · 2024-12-06T18:37:11Z

The stat cards start wrapping into the next line on < 1400px screen widths, and overflowing horizontally when they are lined up.

Chatted with @ilonagl about how we should go about handling this, obviously not ideal that it wraps at that size as its a pretty common view port size - also not ideal to have it overflow. Open to suggestions!

projects/plugins/protect/src/js/routes/home/home-statcards.jsx

* Init project branch * Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Co-authored-by: Nate Weller <[email protected]> * Protect: Update Scan and History headers (#40058) * Update Scan and History section header structure/content * changelog * Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx Co-authored-by: Nate Weller <[email protected]> --------- Co-authored-by: Nate Weller <[email protected]> * Protect: de-emphasize cloud link by using link variant (#40211) * Protect: add ShieldIcon component * Protect: Add ShieldIcon Component (#40402) * Protect: Integrate ThreatsDataViews Component (#40076) * Components: Add ScanReport (#40419) * Fix type errors * Protect: add home page --------- Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Dean Kmyta <[email protected]>

Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Protect: Update Scan and History headers (#40058) Protect: de-emphasize cloud link by using link variant (#40211) Protect: Add ShieldIcon Component (#40402) Protect: Integrate ThreatsDataViews Component (#40076) Components: Add ScanReport (#40419) Protect: Refactor AdminSectionHero (#40516) Protect: Update Scan History extension types (#40548) Protect: Add Home page (#40317) Protect: Integrate ScanReport (#40420) ScanReport: Fix defaultLayout (#40603) Update onboarding popover placement (#40550) Protect Meets Core: Home Page Scan Report Data Adjustments (#40616) Scan Report: Align Status Icon (#40617) Apply max width to hero content (#40618) Protect: Hide Scan Report When No Data (#40619) Protect: Hide Threats Report When No Data (#40620) Protect: Update Threat Icons (#40621) Protect: fix home page stat card spacing (#40623) ScanReport: Disable hiding relevant fields (#40602) Use error variant (#40832) Protect: Restore HistoryAdminSectionHero (#40551) Protect: Separate scan results and history DataViews (#40845) ThreatsDataViews: Improve responsiveness (#40670) ThreatsDataViews: ThreatModal integration (#40202) Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Nov 22, 2024

dkmyta self-assigned this Nov 25, 2024

nateweller force-pushed the add/protect/core branch 2 times, most recently from dcefb9a to 765d821 Compare November 26, 2024 17:46

github-actions bot added [JS Package] Components RNA labels Nov 26, 2024

nateweller force-pushed the add/protect/core branch from 765d821 to 05bae76 Compare November 28, 2024 19:04

nateweller force-pushed the add/protect/core branch 7 times, most recently from 9e76351 to 6c73d5a Compare December 5, 2024 17:49

dkmyta commented Dec 5, 2024

View reviewed changes

dkmyta marked this pull request as ready for review December 5, 2024 22:48

nateweller requested a review from a team December 5, 2024 23:22

nateweller reviewed Dec 6, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/home/home-statcards.jsx Show resolved Hide resolved

nateweller reviewed Dec 6, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/home/home-statcards.jsx Outdated Show resolved Hide resolved

dkmyta deleted the add/protect/home branch December 10, 2024 21:25

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 10, 2024

Protect: Add Home page #40317

Protect: Add Home page #40317

Uh oh!

Conversation

dkmyta commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshots

Uh oh!

github-actions bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkmyta Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

nateweller commented Dec 5, 2024 • edited by dkmyta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nateweller commented Dec 5, 2024 • edited by dkmyta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkmyta commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nateweller commented Dec 5, 2024 • edited by dkmyta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkmyta commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkmyta commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nateweller commented Dec 6, 2024

Uh oh!

dkmyta commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkmyta commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

nateweller commented Dec 5, 2024 •

edited by dkmyta

Loading

nateweller commented Dec 5, 2024 •

edited by dkmyta

Loading

dkmyta commented Dec 5, 2024 •

edited

Loading

nateweller commented Dec 5, 2024 •

edited by dkmyta

Loading

dkmyta commented Dec 5, 2024 •

edited

Loading

dkmyta commented Dec 5, 2024 •

edited

Loading

dkmyta commented Dec 6, 2024 •

edited

Loading