Scan Report: Align Status Icon #40617

nateweller · 2024-12-15T04:28:07Z

Proposed changes:

Applies a min-width to the status icon, in order to visually align the column.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Review the Scan Report storybook or Protect implementation, verify the shield status icon is centered with the column label.

github-actions · 2024-12-15T18:56:35Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

github-actions · 2024-12-15T18:56:59Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect/scan-report-status-min-width branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/protect/scan-report-status-min-width

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/scan-report-status-min-width

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

dkmyta

LGTM

Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Protect: Update Scan and History headers (#40058) Protect: de-emphasize cloud link by using link variant (#40211) Protect: Add ShieldIcon Component (#40402) Protect: Integrate ThreatsDataViews Component (#40076) Components: Add ScanReport (#40419) Protect: Refactor AdminSectionHero (#40516) Protect: Update Scan History extension types (#40548) Protect: Add Home page (#40317) Protect: Integrate ScanReport (#40420) ScanReport: Fix defaultLayout (#40603) Update onboarding popover placement (#40550) Protect Meets Core: Home Page Scan Report Data Adjustments (#40616) Scan Report: Align Status Icon (#40617) Apply max width to hero content (#40618) Protect: Hide Scan Report When No Data (#40619) Protect: Hide Threats Report When No Data (#40620) Protect: Update Threat Icons (#40621) Protect: fix home page stat card spacing (#40623) ScanReport: Disable hiding relevant fields (#40602) Use error variant (#40832) Protect: Restore HistoryAdminSectionHero (#40551) Protect: Separate scan results and history DataViews (#40845) ThreatsDataViews: Improve responsiveness (#40670) ThreatsDataViews: ThreatModal integration (#40202) Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

nateweller requested a review from a team December 15, 2024 04:28

nateweller self-assigned this Dec 15, 2024

nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 15, 2024

nateweller changed the base branch from add/protect/core to fix/protect/home-report-data December 15, 2024 18:55

nateweller force-pushed the add/protect/scan-report-status-min-width branch from 515d3e3 to c448c89 Compare December 15, 2024 18:56

nateweller marked this pull request as ready for review December 15, 2024 18:56

github-actions bot added [JS Package] Components [Status] In Progress RNA labels Dec 15, 2024

nateweller force-pushed the add/protect/scan-report-status-min-width branch from c448c89 to 3b60563 Compare December 15, 2024 19:34

nateweller force-pushed the fix/protect/home-report-data branch from 8d3ff2a to 72df33f Compare December 16, 2024 03:15

nateweller force-pushed the add/protect/scan-report-status-min-width branch from 3b60563 to 279b76b Compare December 16, 2024 03:20

dkmyta approved these changes Dec 16, 2024

View reviewed changes

nateweller and others added 3 commits December 17, 2024 16:35

Init project branch

b04eeff

Protect: minor enhancements to scan report data

eba4892

Remove file extension name property

d16a2a6

nateweller force-pushed the fix/protect/home-report-data branch from 7019369 to d16a2a6 Compare December 17, 2024 23:35

nateweller and others added 3 commits December 17, 2024 16:36

Remove unused import

4b339dc

Init project branch

2f44be8

Scan Report: add min width to status icon to center with column label

ee50c09

nateweller force-pushed the add/protect/scan-report-status-min-width branch from 279b76b to ee50c09 Compare December 17, 2024 23:37

Base automatically changed from fix/protect/home-report-data to add/protect/core December 18, 2024 20:15

nateweller merged commit de503cf into add/protect/core Dec 18, 2024
69 of 72 checks passed

nateweller deleted the add/protect/scan-report-status-min-width branch December 18, 2024 20:16

github-actions bot removed [Status] In Progress [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 18, 2024

nateweller added a commit that referenced this pull request Dec 18, 2024

Scan Report: Align Status Icon (#40617)

3756259

nateweller added a commit that referenced this pull request Dec 26, 2024

Scan Report: Align Status Icon (#40617)

3afda1d

nateweller added a commit that referenced this pull request Dec 31, 2024

Scan Report: Align Status Icon (#40617)

484ce7c

nateweller added a commit that referenced this pull request Jan 6, 2025

Scan Report: Align Status Icon (#40617)

0e4858a

nateweller added a commit that referenced this pull request Jan 12, 2025

Scan Report: Align Status Icon (#40617)

568850a

nateweller added a commit that referenced this pull request Jan 14, 2025

Scan Report: Align Status Icon (#40617)

0b42bf1

nateweller added a commit that referenced this pull request Jan 22, 2025

Scan Report: Align Status Icon (#40617)

e20c532

nateweller added a commit that referenced this pull request Jan 27, 2025

Scan Report: Align Status Icon (#40617)

b779962

nateweller added a commit that referenced this pull request Jan 31, 2025

Scan Report: Align Status Icon (#40617)

a59e988

nateweller added a commit that referenced this pull request Feb 3, 2025

Scan Report: Align Status Icon (#40617)

7c9601b

nateweller added a commit that referenced this pull request Feb 4, 2025

Scan Report: Align Status Icon (#40617)

d7af590

nateweller added a commit that referenced this pull request Feb 5, 2025

Scan Report: Align Status Icon (#40617)

6a2ef28

nateweller added a commit that referenced this pull request Feb 9, 2025

Scan Report: Align Status Icon (#40617)

294361e

nateweller added a commit that referenced this pull request Feb 9, 2025

Scan Report: Align Status Icon (#40617)

f3daf73

nateweller added a commit that referenced this pull request Feb 22, 2025

Scan Report: Align Status Icon (#40617)

bb8fad7

nateweller added a commit that referenced this pull request Mar 18, 2025

Scan Report: Align Status Icon (#40617)

501fb14

nateweller added a commit that referenced this pull request Mar 22, 2025

Scan Report: Align Status Icon (#40617)

21b7ae1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Scan Report: Align Status Icon #40617

Scan Report: Align Status Icon #40617

Uh oh!

nateweller commented Dec 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

github-actions bot commented Dec 15, 2024 •

edited

Loading

Uh oh!

dkmyta left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Scan Report: Align Status Icon #40617

Scan Report: Align Status Icon #40617

Uh oh!

Conversation

nateweller commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

github-actions bot commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkmyta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nateweller commented Dec 15, 2024 •

edited

Loading

github-actions bot commented Dec 15, 2024 •

edited

Loading