Skip to content

Conversation

@dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Dec 10, 2024

Fixes #
Historical scan results must use either "plugins"/"themes" for the extension types.

Proposed changes:

  • Modify types received from endpoint accordingly.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Run this branch of Protect on JT
  • Review the scanHistory initial state property in your console and ensure that each applicable results now as "plugins" or "themes" for threats->extension->type

@dkmyta dkmyta changed the base branch from trunk to add/protect/core December 10, 2024 17:08
@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Dec 10, 2024
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dkmyta dkmyta self-assigned this Dec 10, 2024
@dkmyta dkmyta marked this pull request as ready for review December 10, 2024 17:11
Comment on lines +222 to +224
if ( ! empty( $source_threat->extension ) && in_array( $source_threat->extension->type, array( 'plugin', 'theme' ), true ) ) {
$source_threat->extension->type .= 's';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ( ! empty( $source_threat->extension ) && in_array( $source_threat->extension->type, array( 'plugin', 'theme' ), true ) ) {
$source_threat->extension->type .= 's';
}
// Protect's Extension_Model uses the plural form of "plugin" and "theme" extension types.
if ( ! empty( $source_threat->extension ) && in_array( $source_threat->extension->type, array( 'plugin', 'theme' ), true ) ) {
$source_threat->extension->type .= 's';
}

Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nateweller nateweller merged commit 9a1cb0a into add/protect/core Dec 10, 2024
50 of 51 checks passed
@nateweller nateweller deleted the update/protect/scan-history-extension-types branch December 10, 2024 20:04
nateweller added a commit that referenced this pull request Mar 22, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 22, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 22, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 25, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 25, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 29, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
nateweller added a commit that referenced this pull request Mar 30, 2025
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants