Protect Meets Core: Home Page Scan Report Data Adjustments #40616

nateweller · 2024-12-15T04:21:17Z

Proposed changes:

Conditionally include the "files" item in the scan report data, based on the data source (Scan API includes the file scanning results).
Considers the files item "not checked" if no prior scan has been completed.
Adds a translatable name property to the files item.
Updates the getItemId method from the ScanReport component to compute item IDs based on type, slug, and version to ensure unique IDs without additional data mapping.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Review the files line item on the Protect home page.

github-actions · 2024-12-15T18:42:34Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components, projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-12-15T18:53:39Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/protect/home-report-data branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/protect/home-report-data

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/protect/home-report-data

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

projects/plugins/protect/src/js/routes/home/index.jsx

dkmyta · 2024-12-16T21:54:04Z

projects/js-packages/components/components/scan-report/index.tsx

 	 */
-	const getItemId = useCallback( ( item: ScanReportExtension ) => item.id.toString(), [] );
+	const getItemId = useCallback(
+		( item: ScanReportExtension ) => `${ item.type }_${ item.slug }_${ item.version }`,


Are we certain every item will have a type, slug and version? IIRC the slug for core is null and we don't currently appear to be supply a slug or version property for the files object we pass. Storybook runs fine so it doesn't really appear to matter, perhaps wordpress_null_6.7.1 or files_null_null is fine.

perhaps wordpress_null_6.7.1 or files_null_null is fine.

This was/is my thought, as the generated IDs are still unique, specific to the item, and accurate.

projects/plugins/protect/src/js/routes/home/index.jsx

Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Protect: Update Scan and History headers (#40058) Protect: de-emphasize cloud link by using link variant (#40211) Protect: Add ShieldIcon Component (#40402) Protect: Integrate ThreatsDataViews Component (#40076) Components: Add ScanReport (#40419) Protect: Refactor AdminSectionHero (#40516) Protect: Update Scan History extension types (#40548) Protect: Add Home page (#40317) Protect: Integrate ScanReport (#40420) ScanReport: Fix defaultLayout (#40603) Update onboarding popover placement (#40550) Protect Meets Core: Home Page Scan Report Data Adjustments (#40616) Scan Report: Align Status Icon (#40617) Apply max width to hero content (#40618) Protect: Hide Scan Report When No Data (#40619) Protect: Hide Threats Report When No Data (#40620) Protect: Update Threat Icons (#40621) Protect: fix home page stat card spacing (#40623) ScanReport: Disable hiding relevant fields (#40602) Use error variant (#40832) Protect: Restore HistoryAdminSectionHero (#40551) Protect: Separate scan results and history DataViews (#40845) ThreatsDataViews: Improve responsiveness (#40670) ThreatsDataViews: ThreatModal integration (#40202) Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

nateweller added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Dec 15, 2024

nateweller requested a review from a team December 15, 2024 04:21

nateweller self-assigned this Dec 15, 2024

nateweller mentioned this pull request Dec 15, 2024

ScanReport: Disable hiding relevant fields #40602

Merged

3 tasks

nateweller force-pushed the fix/protect/home-report-data branch from 63b1302 to 7512c64 Compare December 15, 2024 18:41

github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Dec 15, 2024

nateweller force-pushed the fix/protect/home-report-data branch 2 times, most recently from b5e1222 to 8d3ff2a Compare December 15, 2024 18:52

github-actions bot added [JS Package] Components RNA labels Dec 15, 2024

nateweller marked this pull request as ready for review December 15, 2024 18:54

nateweller force-pushed the fix/protect/home-report-data branch from 8d3ff2a to 72df33f Compare December 16, 2024 03:15

dkmyta reviewed Dec 16, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/home/index.jsx Outdated Show resolved Hide resolved

dkmyta reviewed Dec 16, 2024

View reviewed changes

nateweller requested a review from dkmyta December 17, 2024 23:26

nateweller added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress labels Dec 17, 2024

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 17, 2024

nateweller force-pushed the add/protect/core branch from a877b8c to 69a281a Compare December 17, 2024 23:35

nateweller and others added 3 commits December 17, 2024 16:35

Init project branch

b04eeff

Protect: minor enhancements to scan report data

eba4892

Remove file extension name property

d16a2a6

nateweller force-pushed the fix/protect/home-report-data branch from 7019369 to d16a2a6 Compare December 17, 2024 23:35

nateweller commented Dec 17, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/home/index.jsx Outdated Show resolved Hide resolved

Remove unused import

4b339dc

dkmyta approved these changes Dec 18, 2024

View reviewed changes

nateweller merged commit 895043f into add/protect/core Dec 18, 2024
69 of 71 checks passed

nateweller deleted the fix/protect/home-report-data branch December 18, 2024 20:15

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 18, 2024

nateweller added a commit that referenced this pull request Dec 18, 2024

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

79761f7

nateweller added a commit that referenced this pull request Dec 26, 2024

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

f0049ce

nateweller added a commit that referenced this pull request Dec 31, 2024

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

338e67f

nateweller added a commit that referenced this pull request Jan 6, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

989641e

nateweller added a commit that referenced this pull request Jan 12, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

84210ca

nateweller added a commit that referenced this pull request Jan 14, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

69dad41

nateweller added a commit that referenced this pull request Jan 22, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

3a396ad

nateweller added a commit that referenced this pull request Jan 27, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

487c474

nateweller added a commit that referenced this pull request Jan 31, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

7db7e39

nateweller added a commit that referenced this pull request Feb 3, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

c9ba20e

nateweller added a commit that referenced this pull request Feb 4, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

074b200

nateweller added a commit that referenced this pull request Feb 5, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

80fa247

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

dcfd093

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

957f2e0

nateweller added a commit that referenced this pull request Feb 22, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

06bbd54

nateweller added a commit that referenced this pull request Mar 18, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

6a5ef67

nateweller added a commit that referenced this pull request Mar 22, 2025

Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)

4a9294b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Protect Meets Core: Home Page Scan Report Data Adjustments #40616

Protect Meets Core: Home Page Scan Report Data Adjustments #40616

Uh oh!

nateweller commented Dec 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

dkmyta Dec 16, 2024 •

edited

Loading

Uh oh!

nateweller Dec 17, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Protect Meets Core: Home Page Scan Report Data Adjustments #40616

Protect Meets Core: Home Page Scan Report Data Adjustments #40616

Uh oh!

Conversation

nateweller commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dkmyta Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nateweller Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nateweller commented Dec 15, 2024 •

edited

Loading

github-actions bot commented Dec 15, 2024 •

edited

Loading

github-actions bot commented Dec 15, 2024 •

edited

Loading

dkmyta Dec 16, 2024 •

edited

Loading