Protect: fix home page stat card spacing #40623

nateweller · 2024-12-15T20:14:46Z

Proposed changes:

Use flex gap to space home page stat cards, the current selector does not work due to cards being wrapped in an extra <div>.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Proof Read / Check Tests

github-actions · 2024-12-15T20:15:46Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dkmyta · 2024-12-16T22:36:46Z

projects/plugins/protect/src/js/routes/scan/index.jsx

-<<<<<<< HEAD
 	const showResults = !! status.threats.length || hasHistory;
-=======
-	const showResults = status.threats.length || hasHistory;
->>>>>>> 1850b0c9a6 (Protect: only show Threats DataViews when scan is in progress or has results to show)


Introduced in the base PR.

dkmyta

Looks good, aside from needing some conflicts fixed.

…s to show

…results to show

Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Protect: Update Scan and History headers (#40058) Protect: de-emphasize cloud link by using link variant (#40211) Protect: Add ShieldIcon Component (#40402) Protect: Integrate ThreatsDataViews Component (#40076) Components: Add ScanReport (#40419) Protect: Refactor AdminSectionHero (#40516) Protect: Update Scan History extension types (#40548) Protect: Add Home page (#40317) Protect: Integrate ScanReport (#40420) ScanReport: Fix defaultLayout (#40603) Update onboarding popover placement (#40550) Protect Meets Core: Home Page Scan Report Data Adjustments (#40616) Scan Report: Align Status Icon (#40617) Apply max width to hero content (#40618) Protect: Hide Scan Report When No Data (#40619) Protect: Hide Threats Report When No Data (#40620) Protect: Update Threat Icons (#40621) Protect: fix home page stat card spacing (#40623) ScanReport: Disable hiding relevant fields (#40602) Use error variant (#40832) Protect: Restore HistoryAdminSectionHero (#40551) Protect: Separate scan results and history DataViews (#40845) ThreatsDataViews: Improve responsiveness (#40670) ThreatsDataViews: ThreatModal integration (#40202) Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 15, 2024

nateweller requested a review from a team December 15, 2024 20:14

nateweller self-assigned this Dec 15, 2024

github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Dec 15, 2024

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 15, 2024

nateweller force-pushed the update/protect/threat-icons branch from 82263e8 to b5020dd Compare December 16, 2024 02:00

nateweller force-pushed the fix/protect/home-stat-card-gap branch from 7aadefb to cc4dc36 Compare December 16, 2024 02:00

nateweller force-pushed the update/protect/threat-icons branch from b5020dd to dd8fb7f Compare December 16, 2024 03:23

nateweller force-pushed the fix/protect/home-stat-card-gap branch from cc4dc36 to 6cf16bd Compare December 16, 2024 03:24

nateweller force-pushed the update/protect/threat-icons branch from dd8fb7f to 37c57b3 Compare December 16, 2024 04:14

nateweller force-pushed the fix/protect/home-stat-card-gap branch from 6cf16bd to b13df3f Compare December 16, 2024 04:15

nateweller force-pushed the update/protect/threat-icons branch from 37c57b3 to de0a8c3 Compare December 16, 2024 16:29

nateweller force-pushed the fix/protect/home-stat-card-gap branch from b13df3f to 4335e70 Compare December 16, 2024 16:31

dkmyta reviewed Dec 16, 2024

View reviewed changes

dkmyta suggested changes Dec 16, 2024

View reviewed changes

nateweller and others added 13 commits December 17, 2024 16:35

Init project branch

b04eeff

Protect: minor enhancements to scan report data

eba4892

Remove file extension name property

d16a2a6

Remove unused import

4b339dc

Init project branch

2f44be8

Scan Report: add min width to status icon to center with column label

ee50c09

Init project branch

e0ab4db

Apply max width to hero content

3136c28

Init project branch

c3f5cf4

Protect: only show Scan Report when scan is in progress or has result…

a529dba

…s to show

Init project branch

0096404

Protect: only show Scan Report when scan is in progress or has result…

afd7886

…s to show

Protect: only show Threats DataViews when scan is in progress or has …

12484d6

…results to show

Base automatically changed from update/protect/threat-icons to add/protect/core December 18, 2024 20:19

Merge branch 'add/protect/core' into fix/protect/home-stat-card-gap

6b05be3

nateweller merged commit 2a3f2fe into add/protect/core Dec 18, 2024
2 of 3 checks passed

nateweller deleted the fix/protect/home-stat-card-gap branch December 18, 2024 20:20

nateweller added a commit that referenced this pull request Dec 18, 2024

Protect: fix home page stat card spacing (#40623)

aac1879

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 18, 2024

nateweller added a commit that referenced this pull request Dec 26, 2024

Protect: fix home page stat card spacing (#40623)

aa2eac6

nateweller added a commit that referenced this pull request Dec 31, 2024

Protect: fix home page stat card spacing (#40623)

898ae2c

nateweller added a commit that referenced this pull request Jan 6, 2025

Protect: fix home page stat card spacing (#40623)

f040e75

nateweller added a commit that referenced this pull request Jan 12, 2025

Protect: fix home page stat card spacing (#40623)

c9f6be9

nateweller added a commit that referenced this pull request Jan 14, 2025

Protect: fix home page stat card spacing (#40623)

7482dff

nateweller added a commit that referenced this pull request Jan 22, 2025

Protect: fix home page stat card spacing (#40623)

1f2e303

nateweller added a commit that referenced this pull request Jan 27, 2025

Protect: fix home page stat card spacing (#40623)

53b5bee

nateweller added a commit that referenced this pull request Jan 31, 2025

Protect: fix home page stat card spacing (#40623)

abe93d4

nateweller added a commit that referenced this pull request Feb 3, 2025

Protect: fix home page stat card spacing (#40623)

068ad7e

nateweller added a commit that referenced this pull request Feb 4, 2025

Protect: fix home page stat card spacing (#40623)

8f3494b

nateweller added a commit that referenced this pull request Feb 5, 2025

Protect: fix home page stat card spacing (#40623)

f0b8c36

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect: fix home page stat card spacing (#40623)

f67e457

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect: fix home page stat card spacing (#40623)

23f9a7e

nateweller added a commit that referenced this pull request Feb 22, 2025

Protect: fix home page stat card spacing (#40623)

25a9f7f

nateweller added a commit that referenced this pull request Mar 18, 2025

Protect: fix home page stat card spacing (#40623)

657089b

nateweller added a commit that referenced this pull request Mar 22, 2025

Protect: fix home page stat card spacing (#40623)

51f270f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Protect: fix home page stat card spacing #40623

Protect: fix home page stat card spacing #40623

Uh oh!

nateweller commented Dec 15, 2024

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

dkmyta Dec 16, 2024 •

edited

Loading

Uh oh!

dkmyta left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Protect: fix home page stat card spacing #40623

Protect: fix home page stat card spacing #40623

Uh oh!

Conversation

nateweller commented Dec 15, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

dkmyta Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkmyta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkmyta Dec 16, 2024 •

edited

Loading